Store nonAttachedStyle on NodeLayoutData instead of on HashMap in Document.

third_party/WebKit/Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  *
@@ skipping 588 matching lines @@
   if (!node_layout_data->IsSharedEmptyData()) {
     node_layout_data->SetLayoutObject(layout_object);
     return;
   }
 
   if (!layout_object)
     return;
 
   // Swap the NodeLayoutData to point to a new NodeLayoutData instead of the
   // static SharedEmptyData instance.
-  node_layout_data = new NodeLayoutData(layout_object);
+  DCHECK(!node_layout_data->GetNonAttachedStyle());
+  node_layout_data = new NodeLayoutData(layout_object, nullptr);
   if (HasRareData())
     data_.rare_data_->SetNodeLayoutData(node_layout_data);
   else
+    data_.node_layout_data_ = node_layout_data;
+}
+
+void Node::SetNonAttachedStyle(RefPtr<ComputedStyle> non_attached_style) {
+  NodeLayoutData* node_layout_data = HasRareData()
+                                         ? data_.rare_data_->GetNodeLayoutData()
+                                         : data_.node_layout_data_;
+
+  if (!node_layout_data->IsSharedEmptyData()) {
+    if (non_attached_style) {
+      node_layout_data->SetNonAttachedStyle(non_attached_style);
+    } else {
+      if (node_layout_data->GetLayoutObject()) {
+        node_layout_data->SetNonAttachedStyle(nullptr);
+      } else {
+        if (HasRareData()) {
+          data_.rare_data_->SetNodeLayoutData(
+              &NodeLayoutData::SharedEmptyData());
+        } else {
+          data_.node_layout_data_ = &NodeLayoutData::SharedEmptyData();

[rune, 2017/04/26 08:47:28]

Won't this leak the previously set node_layout_data_?

Could we just keep the node_layout_data_ like we do for rare data?

[nainar, 2017/04/27 01:50:06]

Yup, I see what you mean. I have reverted the CL back to the patch where I had
your LGTM last. Sorry about that I thought it was an lgtm with the suggested
change. 

I will take another stab at this when I try to unify the two ComputedStyles. 

+        }
+      }
+    }
+    return;
+  }
+
+  if (!non_attached_style)
+    return;
+
+  // Swap the NodeLayoutData to point to a new NodeLayoutData instead of the
+  // static SharedEmptyData instance.
+  DCHECK(!node_layout_data->GetLayoutObject());
+  node_layout_data = new NodeLayoutData(nullptr, non_attached_style);
+  if (HasRareData())
+    data_.rare_data_->SetNodeLayoutData(node_layout_data);
+  else
     data_.node_layout_data_ = node_layout_data;
 }
 
 LayoutBoxModelObject* Node::GetLayoutBoxModelObject() const {
   LayoutObject* layout_object = this->GetLayoutObject();
   return layout_object && layout_object->IsBoxModelObject()
              ? ToLayoutBoxModelObject(layout_object)
              : nullptr;
 }
 
@@ skipping 1944 matching lines @@
   if (node) {
     std::stringstream stream;
     node->PrintNodePathTo(stream);
     LOG(INFO) << stream.str();
   } else {
     LOG(INFO) << "Cannot showNodePath for <null>";
   }
 }
 
 #endif