Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp

Issue 2821183002: Don't update descendant visual rects on border radius change (Closed)
Patch Set: - Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp b/third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp
index 90c58ca18472f8524ffb724bb05259a4503039cc..923daad5c2eea1efd03e5511342d3ffc29d3e0e7 100644
--- a/third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp
+++ b/third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp
@@ -336,4 +336,26 @@ TEST_P(PrePaintTreeWalkTest, VisualRectClipForceSubtree) {
EXPECT_EQ(75, grandchild->VisualRect().Height());
}
+TEST_P(PrePaintTreeWalkTest, ClipChangeHasRadius) {
+ SetBodyInnerHTML(
+ "<style>"
+ " #target {"
+ " position: absolute;"
+ " z-index: 0;"
+ " overflow: hidden;"
+ " width: 50px;"
+ " height: 50px;"
+ " }"
+ "</style>"
+ "<div id='target'></div>");
+
+ auto* target = GetDocument().GetElementById("target");
+ auto* target_object = ToLayoutBoxModelObject(target->GetLayoutObject());
+ target->setAttribute(HTMLNames::styleAttr, "border-radius: 5px");
+ GetDocument().View()->UpdateAllLifecyclePhasesExceptPaint();
+ EXPECT_TRUE(target_object->Layer()->NeedsRepaint());
+ // And should not trigger any assert failure.
+ GetDocument().View()->UpdateAllLifecyclePhases();
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698