ios/web/navigation/crw_session_controller.h - Issue 2821173002: Handle correctly start and commit of non-latest navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/navigation/crw_session_controller.h

Issue 2821173002: Handle correctly start and commit of non-latest navigations. (Closed)

Patch Set: Fixed eg tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/navigation/crw_session_controller.h

diff --git a/ios/web/navigation/crw_session_controller.h b/ios/web/navigation/crw_session_controller.h

index 4ed7a98d0b56776511224473f27a4e43ca667bec..301f3e3dd6decf7e139e0f0f75ff00fb1e94427e 100644

--- a/ios/web/navigation/crw_session_controller.h

+++ b/ios/web/navigation/crw_session_controller.h

@@ -134,7 +134,8 @@ struct Referrer;

- (void)copyStateFromSessionControllerAndPrune:(CRWSessionController*)source;

// Sets |lastCommittedItemIndex| to the |index| if it's in the entries bounds.

-- (void)goToItemAtIndex:(NSInteger)index;

+// Discards pending and transient entries if |discard| is YES.

+- (void)goToItemAtIndex:(NSInteger)index discardNonCommittedItems:(BOOL)discard;

// Removes the item at |index| after discarding any noncomitted entries.

// |index| must not be the index of the last committed item, or a noncomitted