Handle correctly start and commit of non-latest navigations.

ios/chrome/browser/web/visible_url_egtest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <EarlGrey/EarlGrey.h>
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
+#include "components/version_info/version_info.h"
+#include "ios/chrome/browser/chrome_url_constants.h"
+#import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
+#include "ios/chrome/browser/ui/commands/ios_command_ids.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 #import "ios/chrome/test/app/chrome_test_util.h"
 #import "ios/chrome/test/earl_grey/chrome_earl_grey.h"
 #import "ios/chrome/test/earl_grey/chrome_earl_grey_ui.h"
 #import "ios/chrome/test/earl_grey/chrome_matchers.h"
 #import "ios/chrome/test/earl_grey/chrome_test_case.h"
 #import "ios/web/public/test/http_server.h"
 #include "ios/web/public/test/http_server_util.h"
 #include "ios/web/public/test/response_providers/html_response_provider.h"
 #include "ios/web/public/test/url_test_util.h"
@@ skipping 471 matching lines @@
       assertWithMatcher:grey_notNil()];
 
   // Make server respond so URL1 becomes committed.
   [self setServerPaused:NO];
   [[EarlGrey selectElementWithMatcher:WebViewContainingText(kTestPage1)]
       assertWithMatcher:grey_notNil()];
   [[EarlGrey selectElementWithMatcher:OmniboxText(_testURL1.GetContent())]
       assertWithMatcher:grey_notNil()];
 }
 
+// Tests that visible URL is always the same as last committed URL if user
+// issues 2 go forward commands to WebUI page (crbug.com/711465).
+- (void)testDoubleForwardNavigationToWebUIPage {
+  // Create 3rd entry in the history, to be able to go back twice.
+  [ChromeEarlGrey loadURL:GURL(kChromeUIVersionURL)];
+
+  // Tap the back button twice in the toolbar and wait for URL 1 to load.
+  [[EarlGrey selectElementWithMatcher:chrome_test_util::BackButton()]
+      performAction:grey_tap()];
+  [[EarlGrey selectElementWithMatcher:chrome_test_util::BackButton()]
+      performAction:grey_tap()];
+  [[EarlGrey selectElementWithMatcher:WebViewContainingText(kTestPage1)]
+      assertWithMatcher:grey_notNil()];
+
+  // Quickly navigate forward twice and wait for kChromeUIVersionURL to load.
+  base::scoped_nsobject<GenericChromeCommand> forwardCommand(
+      [[GenericChromeCommand alloc] initWithTag:IDC_FORWARD]);
+  chrome_test_util::RunCommandWithActiveViewController(forwardCommand);
+  chrome_test_util::RunCommandWithActiveViewController(forwardCommand);

[kkhorimoto, 2017/04/18 23:03:15]

Why are we using commands to go forward but UI elements to go back?  Can you add
a comment explaining the reason?

[Eugene But (OOO till 7-30), 2017/04/19 00:26:46]

Done.

+
+  const std::string version = version_info::GetVersionNumber();
+  [[EarlGrey selectElementWithMatcher:WebViewContainingText(version)]
+      assertWithMatcher:grey_notNil()];
+
+  // Make sure that chrome://version URL is displayed in the omnibox.
+  [[EarlGrey selectElementWithMatcher:OmniboxText("chrome://version")]

[kkhorimoto, 2017/04/18 23:03:15]

Can we not use kChromeUIVersionURL?

[Eugene But (OOO till 7-30), 2017/04/19 00:26:46]

No, kChromeUIVersionURL has a trailing slash :(

[kkhorimoto, 2017/04/19 00:34:41]

I think you can use web::GetDisplayTitleForUrl() to convert to the string that
is used.

[Eugene But (OOO till 7-30), 2017/04/19 01:24:36]

I can. Thanks!

+      assertWithMatcher:grey_notNil()];
+}
+
 // Tests that visible URL is always the same as last committed URL if page calls
 // window.history.back() twice.
 - (void)testDoubleBackJSNavigation {
   // Create 3rd entry in the history, to be able to go back twice.
   [ChromeEarlGrey loadURL:_testURL3];
 
   // Purge web view caches and pause the server to make sure that tests can
   // verify omnibox state before server starts responding.
   PurgeCachedWebViewPages();
   [self setServerPaused:YES];
@@ skipping 38 matching lines @@
 - (BOOL)waitForServerToReceiveRequestWithURL:(GURL)URL {
   return [[GREYCondition
       conditionWithName:@"Wait for received request"
                   block:^{
                     return _responseProvider->last_request_url() == URL ? YES
                                                                         : NO;
                   }] waitWithTimeout:10];
 }
 
 @end