Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/safe_browsing/csd.proto

Issue 2821163002: Clean up DownloadAttribution Finch experiments (Closed)
Patch Set: nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_service.cc ('k') | testing/variations/fieldtrial_testing_config.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing/csd.proto
diff --git a/components/safe_browsing/csd.proto b/components/safe_browsing/csd.proto
index 023abe4ffbd71d545a9f2e78426397463fdd8dd8..1c8e3b6c292758951abdfc702b1c573d493a2ce4 100644
--- a/components/safe_browsing/csd.proto
+++ b/components/safe_browsing/csd.proto
@@ -490,7 +490,9 @@ message ClientDownloadRequest {
repeated ReferrerChainEntry referrer_chain = 36;
// Whether DownloadAttribution Finch experiment is enabled for this ping.
lpz 2017/04/20 14:37:02 nit: if deprecated, maybe the legacy comment can b
Jialiu Lin 2017/04/20 18:02:56 Done.
- optional bool download_attribution_finch_enabled = 39;
+ // Deprecated.
+ optional bool DEPRECATED_download_attribution_finch_enabled = 39
+ [deprecated = true];
}
message ReferrerChainEntry {
« chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_service.cc ('k') | testing/variations/fieldtrial_testing_config.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698