Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2147)

Unified Diff: chrome/browser/safe_browsing/download_protection_service.cc

Issue 2821163002: Clean up DownloadAttribution Finch experiments (Closed)
Patch Set: nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/download_protection_service.cc
diff --git a/chrome/browser/safe_browsing/download_protection_service.cc b/chrome/browser/safe_browsing/download_protection_service.cc
index ea221673f46f9284ac8290c7142ecfe7f563a687..95e24fafed0baaebe97f83f05bb43114447fbfc9 100644
--- a/chrome/browser/safe_browsing/download_protection_service.cc
+++ b/chrome/browser/safe_browsing/download_protection_service.cc
@@ -200,9 +200,6 @@ class DownloadUrlSBClient
extended_reporting_level_ =
profile ? GetExtendedReportingLevel(*profile->GetPrefs())
: SBER_LEVEL_OFF;
- download_attribution_enabled_ = service_->navigation_observer_manager() &&
- base::FeatureList::IsEnabled(
- SafeBrowsingNavigationObserverManager::kDownloadAttribution);
}
// Implements DownloadItem::Observer.
@@ -258,14 +255,12 @@ class DownloadUrlSBClient
FROM_HERE,
base::Bind(&DownloadUrlSBClient::ReportMalware,
this, threat_type));
- } else if (download_attribution_enabled_) {
- // Identify download referrer chain, which will be used in
- // ClientDownloadRequest.
- BrowserThread::PostTask(
- BrowserThread::UI,
- FROM_HERE,
- base::Bind(&DownloadUrlSBClient::IdentifyReferrerChain,
- this));
+ } else {
+ // Identify download referrer chain, which will be used in
+ // ClientDownloadRequest.
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(&DownloadUrlSBClient::IdentifyReferrerChain, this));
}
BrowserThread::PostTask(BrowserThread::UI,
FROM_HERE,
@@ -326,7 +321,6 @@ class DownloadUrlSBClient
DownloadProtectionService::CheckDownloadCallback callback_;
scoped_refptr<SafeBrowsingUIManager> ui_manager_;
base::TimeTicks start_time_;
- bool download_attribution_enabled_;
const SBStatsType total_type_;
const SBStatsType dangerous_type_;
ExtendedReportingLevel extended_reporting_level_;
@@ -1049,12 +1043,10 @@ class DownloadProtectionService::CheckClientDownloadRequest
ReferrerChainData* referrer_chain_data =
static_cast<ReferrerChainData*>(
item_->GetUserData(kDownloadReferrerChainDataKey));
- if (referrer_chain_data) {
- request.set_download_attribution_finch_enabled(true);
- if (!referrer_chain_data->GetReferrerChain()->empty()) {
- request.mutable_referrer_chain()->Swap(
- referrer_chain_data->GetReferrerChain());
- }
+ if (referrer_chain_data &&
+ !referrer_chain_data->GetReferrerChain()->empty()) {
+ request.mutable_referrer_chain()->Swap(
+ referrer_chain_data->GetReferrerChain());
}
if (archive_is_valid_ != ArchiveValid::UNSET)
@@ -1673,7 +1665,8 @@ class DownloadProtectionService::PPAPIDownloadRequest
DownloadProtectionService::DownloadProtectionService(
SafeBrowsingService* sb_service)
- : request_context_getter_(sb_service ? sb_service->url_request_context()
+ : navigation_observer_manager_(nullptr),
+ request_context_getter_(sb_service ? sb_service->url_request_context()
: nullptr),
enabled_(false),
binary_feature_extractor_(new BinaryFeatureExtractor()),
@@ -1955,6 +1948,11 @@ GURL DownloadProtectionService::GetDownloadRequestUrl() {
std::unique_ptr<ReferrerChain> DownloadProtectionService::IdentifyReferrerChain(
const GURL& download_url,
content::WebContents* web_contents) {
+ // If navigation_observer_manager_ is null, return immediately. This could
+ // happen in tests.
+ if (!navigation_observer_manager_)
+ return nullptr;
+
std::unique_ptr<ReferrerChain> referrer_chain =
base::MakeUnique<ReferrerChain>();
int download_tab_id = SessionTabHelper::IdForTab(web_contents);
@@ -1993,11 +1991,8 @@ void DownloadProtectionService::AddReferrerChainToPPAPIClientDownloadRequest(
int tab_id,
bool has_user_gesture,
ClientDownloadRequest* out_request) {
- if (!base::FeatureList::IsEnabled(
- SafeBrowsingNavigationObserverManager::kDownloadAttribution) ||
- !navigation_observer_manager_) {
+ if (!navigation_observer_manager_)
return;
- }
UMA_HISTOGRAM_BOOLEAN(
"SafeBrowsing.ReferrerHasInvalidTabID.DownloadAttribution",
@@ -2013,7 +2008,6 @@ void DownloadProtectionService::AddReferrerChainToPPAPIClientDownloadRequest(
UMA_HISTOGRAM_ENUMERATION(
"SafeBrowsing.ReferrerAttributionResult.PPAPIDownloadAttribution", result,
SafeBrowsingNavigationObserverManager::ATTRIBUTION_FAILURE_TYPE_MAX);
- out_request->set_download_attribution_finch_enabled(true);
}
} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698