Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2821143002: Roll gyp e7079f0e:eb296f67

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
Mark Mentovai, scottmg
CC:
chromium-reviews, Mark Mentovai
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll gyp e7079f0e:eb296f67 https://chromium.googlesource.com/external/gyp.git/+log/e7079f0e..eb296f67 eb296f6 [win] Add support for MS VS2017 (via Registry) 95da766 [win-test] loosen win-driver-target-type test aae1e3e CQ config: add gerrit CQAbility verifier. a7055b3 Make Gerrit the default code review system for gyp 9733aa6 Set up a CQ for gyp by Aaron Gable 940a15e Update shared library extension on AIX to .a. ef2f29a msvs: Allow target platform version without WinRT 920ee58 Hash intermediate file name to avoid ENAMETOOLONG 5dc5a5b fix common "NameError"s 702ac58 Add new target type called windows_driver. 93cc6e2 Make the ninja backend transitively check for C++ sources to use the C++ compiler for linking 1f989f6 Complete PBXCopyFilesBuildPhase TODO in xcodeproj_file.py. BUG=700524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Nico
Apparently haven't done that in 9 months!
3 years, 8 months ago (2017-04-17 19:24:13 UTC) #5
Mark Mentovai
LGTM
3 years, 8 months ago (2017-04-17 19:38:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821143002/1
3 years, 8 months ago (2017-04-17 19:43:28 UTC) #10
brucedawson
3 years, 8 months ago (2017-04-17 19:54:32 UTC) #11
On 2017/04/17 19:43:28, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Too late. I just landed https://codereview.chromium.org/2823933002/, which is
identical except for a slightly differently formatted description.

Powered by Google App Engine
This is Rietveld 408576698