Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2821133003: Write loading signal extra data in JSON (Closed)
Patch Set: fix comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_loader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/prerendering_offliner.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.cc b/chrome/browser/android/offline_pages/prerendering_offliner.cc
index db341ef4c87b63951480215df3ff2f69ab5334b3..177ac824d9e278ca109c5e86d40acfd93709cadb 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.cc
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/android/offline_pages/prerendering_offliner.h"
#include "base/bind.h"
+#include "base/json/json_writer.h"
#include "base/metrics/histogram_macros.h"
#include "base/sys_info.h"
#include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
@@ -124,13 +125,10 @@ void PrerenderingOffliner::OnLoadPageDone(
std::string PrerenderingOffliner::SerializeLoadingSignalData() {
// Write the signal data into a single string.
std::string signal_string;
- const std::vector<std::string>& signals = loader_->GetLoadingSignalData();
+ const base::DictionaryValue& signals = loader_->GetLoadingSignalData();
+
+ base::JSONWriter::Write(signals, &signal_string);
- // TODO(petewil): Convert this to JSON, use json_writer.h
- for (std::string signal : signals) {
- signal_string += signal;
- signal_string += "\n";
- }
return signal_string;
}
« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_loader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698