Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader.h

Issue 2821133003: Write loading signal extra data in JSON (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_loader.h
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.h b/chrome/browser/android/offline_pages/prerendering_loader.h
index 5733fecae18f5da049c84eabfb67f5708e37d856..cd48d7984031c6af7daafaab965cba1219f98c95 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.h
+++ b/chrome/browser/android/offline_pages/prerendering_loader.h
@@ -10,6 +10,7 @@
#include <vector>
#include "base/callback.h"
+#include "base/values.h"
#include "chrome/browser/android/offline_pages/prerender_adapter.h"
#include "components/offline_pages/core/background/offliner.h"
#include "components/offline_pages/core/snapshot_controller.h"
@@ -85,9 +86,7 @@ class PrerenderingLoader : public PrerenderAdapter::Observer,
virtual bool IsLowbarMet();
// Returns a vector of strings for analysis of loading progress.
romax 2017/04/18 00:35:09 comments might need to be updated.
Pete Williamson 2017/04/18 18:26:08 Done.
- const std::vector<std::string>& GetLoadingSignalData() {
- return signal_data_;
- }
+ const base::DictionaryValue& GetLoadingSignalData() { return signal_data_; }
private:
// State of the loader (only one request may be active at a time).
@@ -134,7 +133,7 @@ class PrerenderingLoader : public PrerenderAdapter::Observer,
std::unique_ptr<content::WebContents> session_contents_;
// Signal data collected for this rendering attempt
- std::vector<std::string> signal_data_;
+ base::DictionaryValue signal_data_;
// Callback to call when the active load request completes, fails, or is
// canceled.

Powered by Google App Engine
This is Rietveld 408576698