Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 282113004: Implement sendKeyEvent print preview function for OOP PDF. (Closed)

Created:
6 years, 7 months ago by raymes
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Implement sendKeyEvent print preview function for OOP PDF. This implements the function which sends certain key events to the PDF plugin. This allows the document to be scrolled even when it isn't focused. BUG=303491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273823

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -89 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 2 3 chunks +121 lines, -87 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_scripting_api.js View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/pdf/viewport.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
raymes
6 years, 7 months ago (2014-05-15 07:33:22 UTC) #1
Lei Zhang
lgtm with a question: https://codereview.chromium.org/282113004/diff/1/chrome/browser/resources/pdf/viewport.js File chrome/browser/resources/pdf/viewport.js (right): https://codereview.chromium.org/282113004/diff/1/chrome/browser/resources/pdf/viewport.js#newcode57 chrome/browser/resources/pdf/viewport.js:57: * The increment to scroll ...
6 years, 6 months ago (2014-05-28 22:23:54 UTC) #2
raymes
https://codereview.chromium.org/282113004/diff/1/chrome/browser/resources/pdf/viewport.js File chrome/browser/resources/pdf/viewport.js (right): https://codereview.chromium.org/282113004/diff/1/chrome/browser/resources/pdf/viewport.js#newcode57 chrome/browser/resources/pdf/viewport.js:57: * The increment to scroll a page by in ...
6 years, 6 months ago (2014-05-30 07:10:37 UTC) #3
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 6 months ago (2014-05-30 07:41:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/282113004/20001
6 years, 6 months ago (2014-05-30 07:43:17 UTC) #5
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 6 months ago (2014-05-30 07:44:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/282113004/40001
6 years, 6 months ago (2014-05-30 07:46:08 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 12:20:41 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 13:33:39 UTC) #9
Message was sent while issue was closed.
Change committed as 273823

Powered by Google App Engine
This is Rietveld 408576698