Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: extensions/common/permissions/permissions_data.h

Issue 2821123002: Differentiate new permissions from old in extension permission update bubble (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/permissions_data.h
diff --git a/extensions/common/permissions/permissions_data.h b/extensions/common/permissions/permissions_data.h
index 3b87e79bc393161819710e7d8cca9703cc0857e2..e3b43fa78595cf6d8f0e7ba959b9d76e93289f50 100644
--- a/extensions/common/permissions/permissions_data.h
+++ b/extensions/common/permissions/permissions_data.h
@@ -140,6 +140,11 @@ class PermissionsData {
// display at install time, in a nested format ready for display.
PermissionMessages GetPermissionMessages() const;
+ // Returns the full list of new permission details for messages that should
+ // display at install time, in a nested format ready for display.
Devlin 2017/04/20 16:40:53 We should differentiate this from the other method
catmullings 2017/04/20 17:10:38 Done.
+ PermissionMessages GetNewPermissionMessages(
+ const PermissionSet& granted_permissions) const;
+
// Returns true if the extension has requested all-hosts permissions (or
// something close to it), but has had it withheld.
bool HasWithheldImpliedAllHosts() const;

Powered by Google App Engine
This is Rietveld 408576698