Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: extensions/common/permissions/permissions_data.cc

Issue 2821123002: Differentiate new permissions from old in extension permission update bubble (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/permissions_data.cc
diff --git a/extensions/common/permissions/permissions_data.cc b/extensions/common/permissions/permissions_data.cc
index 4025d23c0ff0096e075b60521ae95bb0b0e5675c..beac55a692a4b690c895391b9ca9a94a85a0073e 100644
--- a/extensions/common/permissions/permissions_data.cc
+++ b/extensions/common/permissions/permissions_data.cc
@@ -223,6 +223,19 @@ PermissionMessages PermissionsData::GetPermissionMessages() const {
*active_permissions_unsafe_, manifest_type_));
}
+PermissionMessages PermissionsData::GetNewPermissionMessages(
+ const PermissionSet& granted_permissions) const {
+ base::AutoLock auto_lock(runtime_lock_);
+
+ std::unique_ptr<const PermissionSet> new_permissions =
+ PermissionSet::CreateDifference(*active_permissions_unsafe_,
+ granted_permissions);
+
+ return PermissionMessageProvider::Get()->GetPermissionMessages(
+ PermissionMessageProvider::Get()->GetAllPermissionIDs(*new_permissions,
+ manifest_type_));
+}
+
bool PermissionsData::HasWithheldImpliedAllHosts() const {
base::AutoLock auto_lock(runtime_lock_);
// Since we currently only withhold all_hosts, it's sufficient to check

Powered by Google App Engine
This is Rietveld 408576698