Remove the configuration of Tether-associated Wi-Fi networks once connectivity is lost.

chromeos/components/tether/fake_managed_network_configuration_handler.cc

Index: chromeos/components/tether/fake_managed_network_configuration_handler.cc
diff --git a/chromeos/components/tether/fake_managed_network_configuration_handler.cc b/chromeos/components/tether/fake_managed_network_configuration_handler.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e5e35ee98296d3fc8eb5e9d409ba1bba8d66be27
--- /dev/null
+++ b/chromeos/components/tether/fake_managed_network_configuration_handler.cc
@@ -0,0 +1,103 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/components/tether/fake_managed_network_configuration_handler.h"
+
+namespace chromeos {
+
+namespace tether {
+
+FakeManagedNetworkConfigurationHandler::FakeManagedNetworkConfigurationHandler()
+    : last_removed_configuration_path_(std::string()) {}
+
+void FakeManagedNetworkConfigurationHandler::AddObserver(
+    NetworkPolicyObserver* observer) {}
+void FakeManagedNetworkConfigurationHandler::RemoveObserver(
+    NetworkPolicyObserver* observer) {}
+
+void FakeManagedNetworkConfigurationHandler::GetProperties(
+    const std::string& userhash,
+    const std::string& service_path,
+    const network_handler::DictionaryResultCallback& callback,
+    const network_handler::ErrorCallback& error_callback) {}
+
+void FakeManagedNetworkConfigurationHandler::GetManagedProperties(
+    const std::string& userhash,
+    const std::string& service_path,
+    const network_handler::DictionaryResultCallback& callback,
+    const network_handler::ErrorCallback& error_callback) {}
+
+void FakeManagedNetworkConfigurationHandler::SetProperties(
+    const std::string& service_path,
+    const base::DictionaryValue& user_settings,
+    const base::Closure& callback,
+    const network_handler::ErrorCallback& error_callback) {}
+
+void FakeManagedNetworkConfigurationHandler::CreateConfiguration(
+    const std::string& userhash,
+    const base::DictionaryValue& properties,
+    const network_handler::ServiceResultCallback& callback,
+    const network_handler::ErrorCallback& error_callback) const {}
+
+void FakeManagedNetworkConfigurationHandler::RemoveConfiguration(
+    const std::string& service_path,
+    const base::Closure& callback,
+    const network_handler::ErrorCallback& error_callback) const {
+  // last_removed_configuration_path_ = service_path;

[Kyle Horimoto, 2017/04/17 20:34:53]

Can't you just use this line? You should be able to assign a const string to a
non-const variable.

In any case, don't leave commented-out code in the CL.

[Ryan Hansberry, 2017/04/20 20:57:57]

Removed this file.

+  const_cast<std::string&>(last_removed_configuration_path_) = service_path;

[stevenjb, 2017/04/18 21:03:35]

I'm pretty sure you can do the same thing with a mock using WillOnce or
WillByDefault().

[Ryan Hansberry, 2017/04/20 20:57:57]

Removed this file.

+}
+
+void FakeManagedNetworkConfigurationHandler::
+    RemoveConfigurationFromCurrentProfile(
+        const std::string& service_path,
+        const base::Closure& callback,
+        const network_handler::ErrorCallback& error_callback) const {}
+
+void FakeManagedNetworkConfigurationHandler::SetPolicy(
+    ::onc::ONCSource onc_source,
+    const std::string& userhash,
+    const base::ListValue& network_configs_onc,
+    const base::DictionaryValue& global_network_config) {}
+
+bool FakeManagedNetworkConfigurationHandler::IsAnyPolicyApplicationRunning()
+    const {
+  return false;
+}
+
+const base::DictionaryValue*
+FakeManagedNetworkConfigurationHandler::FindPolicyByGUID(
+    const std::string userhash,
+    const std::string& guid,
+    ::onc::ONCSource* onc_source) const {
+  return nullptr;
+}
+
+const GuidToPolicyMap*
+FakeManagedNetworkConfigurationHandler::GetNetworkConfigsFromPolicy(
+    const std::string& userhash) const {
+  return nullptr;
+}
+
+const base::DictionaryValue*
+FakeManagedNetworkConfigurationHandler::GetGlobalConfigFromPolicy(
+    const std::string& userhash) const {
+  return nullptr;
+}
+
+const base::DictionaryValue*
+FakeManagedNetworkConfigurationHandler::FindPolicyByGuidAndProfile(
+    const std::string& guid,
+    const std::string& profile_path) const {
+  return nullptr;
+}
+
+const std::string&
+FakeManagedNetworkConfigurationHandler::last_removed_configuration_path()
+    const {
+  return last_removed_configuration_path_;
+}
+
+}  // namespace tether
+
+}  // namespace chromeos