Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: net/url_request/url_request_intercepting_job_factory.cc

Issue 282103004: Rename ProtocolInterceptJobFactory and make it not use ProtocolHandlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Response to jam's comments (And a merge) Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_intercepting_job_factory.h ('k') | net/url_request/url_request_interceptor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_intercepting_job_factory.cc
diff --git a/net/url_request/protocol_intercept_job_factory.cc b/net/url_request/url_request_intercepting_job_factory.cc
similarity index 51%
rename from net/url_request/protocol_intercept_job_factory.cc
rename to net/url_request/url_request_intercepting_job_factory.cc
index d0f92f4bff376c1c7a26cacdb92ab0cca31b16be..d22a00adcaeb41ac78b0616125366787f55b6171 100644
--- a/net/url_request/protocol_intercept_job_factory.cc
+++ b/net/url_request/url_request_intercepting_job_factory.cc
@@ -2,44 +2,46 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "net/url_request/protocol_intercept_job_factory.h"
+#include "net/url_request/url_request_intercepting_job_factory.h"
#include "base/logging.h"
+#include "net/url_request/url_request_interceptor.h"
namespace net {
-ProtocolInterceptJobFactory::ProtocolInterceptJobFactory(
+URLRequestInterceptingJobFactory::URLRequestInterceptingJobFactory(
scoped_ptr<URLRequestJobFactory> job_factory,
- scoped_ptr<ProtocolHandler> protocol_handler)
+ scoped_ptr<URLRequestInterceptor> interceptor)
: job_factory_(job_factory.Pass()),
- protocol_handler_(protocol_handler.Pass()) {
+ interceptor_(interceptor.Pass()) {
}
-ProtocolInterceptJobFactory::~ProtocolInterceptJobFactory() {}
+URLRequestInterceptingJobFactory::~URLRequestInterceptingJobFactory() {}
-URLRequestJob* ProtocolInterceptJobFactory::MaybeCreateJobWithProtocolHandler(
+URLRequestJob* URLRequestInterceptingJobFactory::
+MaybeCreateJobWithProtocolHandler(
const std::string& scheme,
URLRequest* request,
NetworkDelegate* network_delegate) const {
DCHECK(CalledOnValidThread());
- URLRequestJob* job = protocol_handler_->MaybeCreateJob(request,
- network_delegate);
+ URLRequestJob* job = interceptor_->MaybeInterceptRequest(request,
+ network_delegate);
if (job)
return job;
return job_factory_->MaybeCreateJobWithProtocolHandler(
scheme, request, network_delegate);
}
-bool ProtocolInterceptJobFactory::IsHandledProtocol(
+bool URLRequestInterceptingJobFactory::IsHandledProtocol(
const std::string& scheme) const {
return job_factory_->IsHandledProtocol(scheme);
}
-bool ProtocolInterceptJobFactory::IsHandledURL(const GURL& url) const {
+bool URLRequestInterceptingJobFactory::IsHandledURL(const GURL& url) const {
return job_factory_->IsHandledURL(url);
}
-bool ProtocolInterceptJobFactory::IsSafeRedirectTarget(
+bool URLRequestInterceptingJobFactory::IsSafeRedirectTarget(
const GURL& location) const {
return job_factory_->IsSafeRedirectTarget(location);
}
« no previous file with comments | « net/url_request/url_request_intercepting_job_factory.h ('k') | net/url_request/url_request_interceptor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698