content/browser/storage_partition_impl_map.cc - Issue 282103004: Rename ProtocolInterceptJobFactory and make it not use ProtocolHandlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/storage_partition_impl_map.cc

Issue 282103004: Rename ProtocolInterceptJobFactory and make it not use ProtocolHandlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Response to jam's comments (And a merge) Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_request_handler.cc ('k') | content/public/browser/content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/storage_partition_impl_map.cc

diff --git a/content/browser/storage_partition_impl_map.cc b/content/browser/storage_partition_impl_map.cc

index d4104b89d64156cd6c870bdea9b6df1ef7cbbd0d..16fc2fe6c57908ed60d84efaba57c7a4175f3a68 100644

--- a/content/browser/storage_partition_impl_map.cc

+++ b/content/browser/storage_partition_impl_map.cc

@@ -413,8 +413,8 @@ StoragePartitionImpl* StoragePartitionImplMap::Get(

CreateDevToolsProtocolHandler(browser_context_->GetResourceContext(),

browser_context_->IsOffTheRecord()));

- ProtocolHandlerScopedVector protocol_interceptors;

- protocol_interceptors.push_back(

+ URLRequestInterceptorScopedVector request_interceptors;

+ request_interceptors.push_back(

ServiceWorkerRequestHandler::CreateInterceptor().release());

// These calls must happen after StoragePartitionImpl::Create().

@@ -423,7 +423,7 @@ StoragePartitionImpl* StoragePartitionImplMap::Get(

GetContentClient()->browser()->CreateRequestContext(

browser_context_,

&protocol_handlers,

- protocol_interceptors.Pass()));

+ request_interceptors.Pass()));

} else {

partition->SetURLRequestContext(

GetContentClient()->browser()->CreateRequestContextForStoragePartition(

@@ -431,7 +431,7 @@ StoragePartitionImpl* StoragePartitionImplMap::Get(

partition->GetPath(),

in_memory,

&protocol_handlers,

- protocol_interceptors.Pass()));

+ request_interceptors.Pass()));

}

partition->SetMediaURLRequestContext(

partition_domain.empty() ?