Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: chrome/browser/extensions/extension_ui_util.cc

Issue 282103003: Moved IS_EPHEMERAL flag to extension prefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor refactoring. Added comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_ui_util.cc
diff --git a/chrome/browser/extensions/extension_ui_util.cc b/chrome/browser/extensions/extension_ui_util.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ab8c5ac0a717f94934042b769f01546b40264cef
--- /dev/null
+++ b/chrome/browser/extensions/extension_ui_util.cc
@@ -0,0 +1,58 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_ui_util.h"
+
+#include "base/prefs/pref_service.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/extensions/extension_constants.h"
+#include "chrome/common/pref_names.h"
+#include "extensions/browser/extension_util.h"
+#include "extensions/common/extension.h"
+
+namespace extensions {
+
+namespace {
+
+bool IsBlockedByPolicy(const Extension* app, content::BrowserContext* context) {
+ Profile* profile = Profile::FromBrowserContext(context);
+ DCHECK(profile);
+
+ return (app->id() == extension_misc::kWebStoreAppId ||
+ app->id() == extension_misc::kEnterpriseWebStoreAppId) &&
+ profile->GetPrefs()->GetBoolean(prefs::kHideWebStoreIcon);
+}
+
+} // namespace
+
+namespace ui_util {
+
+bool ShouldDisplayInAppLauncher(const Extension* extension,
+ content::BrowserContext* context) {
+ return extension->ShouldDisplayInAppLauncher() &&
+ !IsBlockedByPolicy(extension, context) &&
+ !util::IsEphemeralApp(extension->id(), context);
+}
+
+bool ShouldDisplayInNewTabPage(const Extension* extension,
+ content::BrowserContext* context) {
+ return extension->ShouldDisplayInNewTabPage() &&
+ !IsBlockedByPolicy(extension, context) &&
+ !util::IsEphemeralApp(extension->id(), context);
+}
+
+bool ShouldDisplayInExtensionSettings(const Extension* extension,
+ content::BrowserContext* context) {
+ return extension->ShouldDisplayInExtensionSettings() &&
+ !util::IsEphemeralApp(extension->id(), context);
+}
+
+bool ShouldNotBeVisible(const Extension* extension,
+ content::BrowserContext* context) {
+ return extension->ShouldNotBeVisible() ||
+ util::IsEphemeralApp(extension->id(), context);
+}
+
+} // namespace ui_util
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698