Moved IS_EPHEMERAL flag to extension prefs

chrome/browser/extensions/extension_ui_util.cc

Index: chrome/browser/extensions/extension_ui_util.cc
diff --git a/chrome/browser/extensions/extension_ui_util.cc b/chrome/browser/extensions/extension_ui_util.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ab8c5ac0a717f94934042b769f01546b40264cef
--- /dev/null
+++ b/chrome/browser/extensions/extension_ui_util.cc
@@ -0,0 +1,58 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_ui_util.h"
+
+#include "base/prefs/pref_service.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/extensions/extension_constants.h"
+#include "chrome/common/pref_names.h"
+#include "extensions/browser/extension_util.h"
+#include "extensions/common/extension.h"
+
+namespace extensions {
+
+namespace {
+
+bool IsBlockedByPolicy(const Extension* app, content::BrowserContext* context) {

[tmdiep, 2014/05/15 02:18:42]

There is some deviation from previous behavior here.

Previously, only app_launcher_handler.cc (for NTP) and
extension_app_model_builder.cc (for app launcher) checked the HideWebStoreIcon
pref. But if the web store icon is hidden there, I think it makes sense to also
hide it in other locations, e.g. extension_app_provider.cc (autocomplete),
app_search_provider.cc (search in app launcher), recommended_apps.cc (app
launcher), etc.

If I should just conform to the previous behavior, I can fix this patch.

+  Profile* profile = Profile::FromBrowserContext(context);
+  DCHECK(profile);
+
+  return (app->id() == extension_misc::kWebStoreAppId ||
+      app->id() == extension_misc::kEnterpriseWebStoreAppId) &&
+      profile->GetPrefs()->GetBoolean(prefs::kHideWebStoreIcon);
+}
+
+}  // namespace
+
+namespace ui_util {
+
+bool ShouldDisplayInAppLauncher(const Extension* extension,
+                                content::BrowserContext* context) {
+  return extension->ShouldDisplayInAppLauncher() &&
+      !IsBlockedByPolicy(extension, context) &&
+      !util::IsEphemeralApp(extension->id(), context);
+}
+
+bool ShouldDisplayInNewTabPage(const Extension* extension,
+                               content::BrowserContext* context) {
+  return extension->ShouldDisplayInNewTabPage() &&
+      !IsBlockedByPolicy(extension, context) &&
+      !util::IsEphemeralApp(extension->id(), context);
+}
+
+bool ShouldDisplayInExtensionSettings(const Extension* extension,
+                                      content::BrowserContext* context) {
+  return extension->ShouldDisplayInExtensionSettings() &&
+      !util::IsEphemeralApp(extension->id(), context);
+}
+
+bool ShouldNotBeVisible(const Extension* extension,
+                        content::BrowserContext* context) {
+  return extension->ShouldNotBeVisible() ||
+      util::IsEphemeralApp(extension->id(), context);
+}
+
+}  // namespace ui_util
+}  // namespace extensions