chrome/browser/ui/app_list/app_list_test_util.h - Issue 282103003: Moved IS_EPHEMERAL flag to extension prefs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/app_list/app_list_test_util.h

Issue 282103003: Moved IS_EPHEMERAL flag to extension prefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor refactoring. Added comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_TEST_UTIL_H_
	benwells 2014/05/19 02:06:53 Is this part of your change? Is this part of your change? tmdiep 2014/05/19 02:51:16 Yes. I added a test for ephemeral apps to extensio Show quoted text On 2014/05/19 02:06:53, benwells wrote: > Is this part of your change? Yes. I added a test for ephemeral apps to extension_app_model_builder_unittest.cc and app_search_provider_unittest.cc, and saw that they duplicated a chunk of code in order to use a common set of test files. So refactored that bit into this class to avoid making the same change in 2 different places.
	6 #define CHROME_BROWSER_UI_APP_LIST_APP_LIST_TEST_UTIL_H_

	7

	8 #include "chrome/browser/extensions/extension_service_unittest.h"

	9

	10 // Base class for app list unit tests that use the "app_list" test profile.

	11 class AppListTestBase : public ExtensionServiceTestBase {

	12 public:

	13 static const char kHostedAppId[];

	14 static const char kPackagedApp1Id[];

	15 static const char kPackagedApp2Id[];

	16

	17 AppListTestBase();

	18 virtual ~AppListTestBase();

	19

	20 virtual void SetUp() OVERRIDE;

	21 };

	22

	23 #endif // CHROME_BROWSER_UI_APP_LIST_APP_LIST_TEST_UTIL_H_

OLD	NEW