Moved IS_EPHEMERAL flag to extension prefs

chrome/browser/extensions/crx_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/crx_installer.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 114 matching lines @@
       allow_silent_install_(false),
       install_cause_(extension_misc::INSTALL_CAUSE_UNSET),
       creation_flags_(Extension::NO_FLAGS),
       off_store_install_allow_reason_(OffStoreInstallDisallowed),
       did_handle_successfully_(true),
       error_on_unsupported_requirements_(false),
       has_requirement_errors_(false),
       blacklist_state_(extensions::NOT_BLACKLISTED),
       install_wait_for_idle_(true),
       update_from_settings_page_(false),
+      is_ephemeral_(false),
       installer_(service_weak->profile()) {
   installer_task_runner_ = service_weak->GetFileTaskRunner();
   if (!approval)
     return;
 
   CHECK(profile()->IsSameProfile(approval->profile));
   if (client_) {
     client_->install_ui()->SetUseAppInstalledBubble(
         approval->use_app_installed_bubble);
     client_->install_ui()->set_skip_post_install_ui(
         approval->skip_post_install_ui);
   }
 
   if (approval->skip_install_dialog) {
     // Mark the extension as approved, but save the expected manifest and ID
     // so we can check that they match the CRX's.
     approved_ = true;
     expected_manifest_check_level_ = approval->manifest_check_level;
     if (expected_manifest_check_level_ !=
         WebstoreInstaller::MANIFEST_CHECK_LEVEL_NONE)
       expected_manifest_.reset(approval->manifest->DeepCopy());
     expected_id_ = approval->extension_id;
   }
   if (approval->minimum_version.get()) {
     expected_version_.reset(new Version(*approval->minimum_version));
     expected_version_strict_checking_ = false;
   }
 
   show_dialog_callback_ = approval->show_dialog_callback;
-
-  if (approval->is_ephemeral)
-    creation_flags_ |= Extension::IS_EPHEMERAL;
+  is_ephemeral_ = approval->is_ephemeral;
 }
 
 CrxInstaller::~CrxInstaller() {
   // Make sure the UI is deleted on the ui thread.
   if (client_) {
     BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, client_);
     client_ = NULL;
   }
 }
 
@@ skipping 628 matching lines @@
     if (client_ || allow_silent_install_) {
       PermissionsUpdater perms_updater(profile());
       perms_updater.GrantActivePermissions(extension());
     }
   }
 
   service_weak_->OnExtensionInstalled(extension(),
                                       page_ordinal_,
                                       has_requirement_errors_,
                                       blacklist_state_,
+                                      is_ephemeral_,
                                       install_wait_for_idle_);
   NotifyCrxInstallComplete(true);
 }
 
 void CrxInstaller::NotifyCrxInstallBegin() {
   InstallTrackerFactory::GetForProfile(profile())
       ->OnBeginCrxInstall(expected_id_);
 }
 
 void CrxInstaller::NotifyCrxInstallComplete(bool success) {
@@ skipping 72 matching lines @@
   if (!prefs->DidExtensionEscalatePermissions(extension()->id()))
     return;
 
   if (client_) {
     AddRef();  // Balanced in InstallUIProceed() and InstallUIAbort().
     client_->ConfirmReEnable(this, extension());
   }
 }
 
 }  // namespace extensions