Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 2821023002: Change unique_ptr::reset() for std::move

Created:
3 years, 8 months ago by Uzair
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change unique_ptr::reset() for std::move BUG=644626 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/gpu/v4l2_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Uzair
On 2017/04/17 11:02:47, Uzair wrote: > mailto:uzair.jaleel@samsung.com changed reviewers: > + mailto:posciak@chromium.org Dear posciak PTAL ...
3 years, 8 months ago (2017-04-17 11:03:11 UTC) #4
Uzair
On 2017/04/17 11:03:11, Uzair wrote: > On 2017/04/17 11:02:47, Uzair wrote: > > mailto:uzair.jaleel@samsung.com changed ...
3 years, 8 months ago (2017-04-18 04:04:33 UTC) #6
DaleCurtis
lgtm
3 years, 8 months ago (2017-04-18 18:18:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821023002/1
3 years, 8 months ago (2017-04-19 03:58:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/322124)
3 years, 8 months ago (2017-04-19 04:26:37 UTC) #11
Uzair
On 2017/04/19 04:26:37, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-25 09:40:52 UTC) #12
Uzair
3 years, 8 months ago (2017-04-25 09:41:37 UTC) #13
On 2017/04/25 09:40:52, Uzair wrote:
> On 2017/04/19 04:26:37, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
> > (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
> 
> Below is the error
> 
> Wno-unknown-warning-option -Wno-inline-asm -c
> ../../media/gpu/v4l2_video_decode_accelerator.cc -o
> obj/media/gpu/gpu/v4l2_video_decode_accelerator.o
> ../../media/gpu/v4l2_video_decode_accelerator.cc:822:39: error: no viable
> overloaded '=' decoder_current_bitstream_buffer_ = std::move(buffer_ref);


This is failing for chromeos any input regarding fixing this would be helpfull

thanks

Powered by Google App Engine
This is Rietveld 408576698