Issue 2821019: Do not try to resolve empty hostnames.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2821019: Do not try to resolve empty hostnames. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by jochen

Modified:
4 years ago

Reviewers:
Aaron Boodman, eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Do not try to resolve empty hostnames. BUG=47501 TEST=none

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/proxy/proxy_resolver_v8.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Trybot results: linux win mac

Total messages: 3 (0 generated)

jochen

please review. There's a DCHECK for non-empty hostname in chrome/browser/net/dns_global.cc that gets triggered from here.

4 years, 11 months ago (2010-06-25 08:18:26 UTC) #1

jochen

4 years, 11 months ago (2010-06-25 10:27:57 UTC) #3

On 2010/06/25 08:21:23, Aaron Boodman wrote:
> lgtm

turns out an empty hostname is valid for this function and should return
127.0.0.1