Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1718)

Unified Diff: chrome/browser/tabs/tab_strip_model_order_controller.h

Issue 2821011: Removes phantom tabs. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tabs/tab_strip_model.cc ('k') | chrome/browser/tabs/tab_strip_model_order_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tabs/tab_strip_model_order_controller.h
diff --git a/chrome/browser/tabs/tab_strip_model_order_controller.h b/chrome/browser/tabs/tab_strip_model_order_controller.h
index f0ff2653ceeba8f95d5a17c75b71ccd0eccbd447..b3b59268a4449e8db991b7175c4c237ffd4e40ae 100644
--- a/chrome/browser/tabs/tab_strip_model_order_controller.h
+++ b/chrome/browser/tabs/tab_strip_model_order_controller.h
@@ -38,11 +38,8 @@ class TabStripModelOrderController : public TabStripModelObserver {
// Returns the index to append tabs at.
int DetermineInsertionIndexForAppending();
- // Determine where to shift selection after a tab is closed is made phantom.
- // If |is_remove| is false, the tab is not being removed but rather made
- // phantom (see description of phantom tabs in TabStripModel).
- int DetermineNewSelectedIndex(int removed_index,
- bool is_remove) const;
+ // Determine where to shift selection after a tab is closed.
+ int DetermineNewSelectedIndex(int removed_index) const;
// Overridden from TabStripModelObserver:
virtual void TabSelectedAt(TabContents* old_contents,
@@ -52,10 +49,8 @@ class TabStripModelOrderController : public TabStripModelObserver {
private:
// Returns a valid index to be selected after the tab at |removing_index| is
- // closed. If |index| is after |removing_index| and |is_remove| is true,
- // |index| is adjusted to reflect the fact that |removing_index| is going
- // away. This also skips any phantom tabs.
- int GetValidIndex(int index, int removing_index, bool is_remove) const;
+ // closed.
+ int GetValidIndex(int index, int removing_index) const;
TabStripModel* tabstrip_;
« no previous file with comments | « chrome/browser/tabs/tab_strip_model.cc ('k') | chrome/browser/tabs/tab_strip_model_order_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698