Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: chrome/browser/gtk/tabs/tab_renderer_gtk.cc

Issue 2821011: Removes phantom tabs. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/tabs/tab_renderer_gtk.h ('k') | chrome/browser/gtk/tabs/tab_strip_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/tabs/tab_renderer_gtk.cc
diff --git a/chrome/browser/gtk/tabs/tab_renderer_gtk.cc b/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
index df16d83454dc7955e397aacd28cedcb9b3cd193f..c82a19a930c692538d0954d9141fd387594fb0f8 100644
--- a/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
+++ b/chrome/browser/gtk/tabs/tab_renderer_gtk.cc
@@ -274,7 +274,6 @@ TabRendererGtk::~TabRendererGtk() {
}
void TabRendererGtk::UpdateData(TabContents* contents,
- bool phantom,
bool loading_only) {
DCHECK(contents);
@@ -285,7 +284,6 @@ void TabRendererGtk::UpdateData(TabContents* contents,
data_.off_the_record = contents->profile()->IsOffTheRecord();
data_.crashed = contents->is_crashed();
data_.favicon = contents->GetFavIcon();
- data_.phantom = phantom;
// This is kind of a hacky way to determine whether our icon is the default
// favicon. But the plumbing that would be necessary to do it right would
// be a good bit of work and would sully code for other platforms which
@@ -604,12 +602,7 @@ void TabRendererGtk::Paint(gfx::Canvas* canvas) {
show_close_button != showing_close_button_)
Layout();
- if (!phantom()) {
- // TODO: this isn't quite right. To match the Windows side we need to render
- // phantom tabs to a separate layer than alpha composite that. This will do
- // for now though.
- PaintTabBackground(canvas);
- }
+ PaintTabBackground(canvas);
if (!mini() || width() > kMiniTabRendererAsNormalTabWidth)
PaintTitle(canvas);
« no previous file with comments | « chrome/browser/gtk/tabs/tab_renderer_gtk.h ('k') | chrome/browser/gtk/tabs/tab_strip_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698