Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: chrome/browser/browser.cc

Issue 2821011: Removes phantom tabs. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser.h ('k') | chrome/browser/browser_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser.cc
diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc
index dbf62e92c104076dbef697b033fe8faff6b7056d..7103418c7af25f59f56158eec14a80f0f4df9d97 100644
--- a/chrome/browser/browser.cc
+++ b/chrome/browser/browser.cc
@@ -240,7 +240,7 @@ Browser::Browser(Type type, Profile* profile)
Browser::~Browser() {
// The tab strip should not have any significant tabs at this point.
- DCHECK(!tabstrip_model_.HasNonPhantomTabs());
+ DCHECK(tabstrip_model_.empty());
tabstrip_model_.RemoveObserver(this);
BrowserList::RemoveBrowser(this);
@@ -2351,21 +2351,6 @@ void Browser::TabMoved(TabContents* contents,
SyncHistoryWithTabs(std::min(from_index, to_index));
}
-void Browser::TabReplacedAt(TabContents* old_contents,
- TabContents* new_contents, int index) {
- TabDetachedAtImpl(old_contents, index, DETACH_TYPE_REPLACE);
- TabInsertedAt(new_contents, index,
- (index == tabstrip_model_.selected_index()));
-
- int entry_count = new_contents->controller().entry_count();
- if (entry_count > 0) {
- // Send out notification so that observers are updated appropriately.
- new_contents->controller().NotifyEntryChanged(
- new_contents->controller().GetEntryAtIndex(entry_count - 1),
- entry_count - 1);
- }
-}
-
void Browser::TabPinnedStateChanged(TabContents* contents, int index) {
if (!profile()->HasSessionService())
return;
« no previous file with comments | « chrome/browser/browser.h ('k') | chrome/browser/browser_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698