Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6359)

Unified Diff: chrome/browser/extensions/extension_message_service.cc

Issue 2821011: Removes phantom tabs. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_message_service.cc
diff --git a/chrome/browser/extensions/extension_message_service.cc b/chrome/browser/extensions/extension_message_service.cc
index 2c7f693eb2f4d2e64b05582d7c12ace681624ea2..c62de9775c12ad6771ce1ca01479081ad312955c 100644
--- a/chrome/browser/extensions/extension_message_service.cc
+++ b/chrome/browser/extensions/extension_message_service.cc
@@ -303,8 +303,8 @@ void ExtensionMessageService::OpenChannelToTabOnUIThread(
}
if (contents && contents->controller().needs_reload()) {
- // The tab isn't loaded yet (it may be phantom). Don't attempt to connect.
- // Treat this as a disconnect.
+ // The tab isn't loaded yet (it needs to be restored). Don't attempt to
+ // connect. Treat this as a disconnect.
DispatchOnDisconnect(MessagePort(source, MSG_ROUTING_CONTROL),
GET_OPPOSITE_PORT_ID(receiver_port_id));
return;
@@ -400,7 +400,8 @@ int ExtensionMessageService::OpenSpecialChannelToTab(
DCHECK(target_tab_contents);
if (target_tab_contents->controller().needs_reload()) {
- // The tab isn't loaded yet (it may be phantom). Don't attempt to connect.
+ // The tab isn't loaded yet (it needs to be reloaded). Don't attempt to
+ // connect.
return -1;
}
« no previous file with comments | « chrome/browser/extensions/extension_browser_event_router.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698