Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 2820953002: Use shorter names for some standard properties on closures. (Closed)
Patch Set: revert call* - used by mirrors Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/minify_namer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/namer.dart
diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart
index 3fd530b20f424a31d600186a84efd765fba1cd92..ff9dbcf8d4c6d77969591bd99d54372b5aa921dc 100644
--- a/pkg/compiler/lib/src/js_backend/namer.dart
+++ b/pkg/compiler/lib/src/js_backend/namer.dart
@@ -442,20 +442,22 @@ class Namer {
final String superPrefix = r'super$';
final String metadataField = '@';
final String callPrefix = 'call';
- final String callCatchAllName = r'call*';
+ // Note: We can't shorten 'call*' in the minified namers because the catch-all
+ // formula `name + "*"` is used by mirrors.
+ String get callCatchAllName => r'call*';
final String callNameField = r'$callName';
final String stubNameField = r'$stubName';
final String reflectableField = r'$reflectable';
final String reflectionInfoField = r'$reflectionInfo';
final String reflectionNameField = r'$reflectionName';
final String metadataIndexField = r'$metadataIndex';
- final String defaultValuesField = r'$defaultValues';
+ String get requiredParameterField => r'$requiredArgCount';
+ String get defaultValuesField => r'$defaultValues';
final String methodsWithOptionalArgumentsField =
r'$methodsWithOptionalArguments';
final String deferredAction = r'$deferredAction';
final String classDescriptorProperty = r'^';
- final String requiredParameterField = r'$requiredArgCount';
/// The non-minifying namer's [callPrefix] with a dollar after it.
static const String _callPrefixDollar = r'call$';
« no previous file with comments | « pkg/compiler/lib/src/js_backend/minify_namer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698