Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: chrome/browser/subresource_filter/chrome_subresource_filter_client.h

Issue 2820933002: [subresource_filter] add //chrome level unit test harness (Closed)
Patch Set: add a few #includes (trybots prev) Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SUBRESOURCE_FILTER_CHROME_SUBRESOURCE_FILTER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_SUBRESOURCE_FILTER_CHROME_SUBRESOURCE_FILTER_CLIENT_H_
6 #define CHROME_BROWSER_SUBRESOURCE_FILTER_CHROME_SUBRESOURCE_FILTER_CLIENT_H_ 6 #define CHROME_BROWSER_SUBRESOURCE_FILTER_CHROME_SUBRESOURCE_FILTER_CLIENT_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/content_settings/core/common/content_settings.h" 9 #include "components/content_settings/core/common/content_settings.h"
10 #include "components/subresource_filter/content/browser/subresource_filter_clien t.h" 10 #include "components/subresource_filter/content/browser/subresource_filter_clien t.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 explicit ChromeSubresourceFilterClient(content::WebContents* web_contents); 63 explicit ChromeSubresourceFilterClient(content::WebContents* web_contents);
64 ~ChromeSubresourceFilterClient() override; 64 ~ChromeSubresourceFilterClient() override;
65 65
66 // SubresourceFilterClient: 66 // SubresourceFilterClient:
67 void ToggleNotificationVisibility(bool visibility) override; 67 void ToggleNotificationVisibility(bool visibility) override;
68 bool IsWhitelistedByContentSettings(const GURL& url) override; 68 bool IsWhitelistedByContentSettings(const GURL& url) override;
69 void WhitelistByContentSettings(const GURL& url) override; 69 void WhitelistByContentSettings(const GURL& url) override;
70 subresource_filter::VerifiedRulesetDealer::Handle* GetRulesetDealer() 70 subresource_filter::VerifiedRulesetDealer::Handle* GetRulesetDealer()
71 override; 71 override;
72 72
73 bool shown_for_navigation() { return shown_for_navigation_; }
engedy 2017/04/20 12:34:33 nit: How about {did_show|shown}_ui_for_navigation(
Charlie Harrison 2017/04/20 15:55:20 Done, I've also changed the underlying member to b
74
73 static void LogAction(SubresourceFilterAction action); 75 static void LogAction(SubresourceFilterAction action);
74 76
75 private: 77 private:
76 ContentSetting GetContentSettingForUrl(const GURL& url); 78 ContentSetting GetContentSettingForUrl(const GURL& url);
77 content::WebContents* web_contents_; 79 content::WebContents* web_contents_;
78 bool shown_for_navigation_; 80 bool shown_for_navigation_;
79 81
80 DISALLOW_COPY_AND_ASSIGN(ChromeSubresourceFilterClient); 82 DISALLOW_COPY_AND_ASSIGN(ChromeSubresourceFilterClient);
81 }; 83 };
82 84
83 #endif // CHROME_BROWSER_SUBRESOURCE_FILTER_CHROME_SUBRESOURCE_FILTER_CLIENT_H_ 85 #endif // CHROME_BROWSER_SUBRESOURCE_FILTER_CHROME_SUBRESOURCE_FILTER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698