chrome/browser/ui/webui/crashes_ui.cc - Issue 282093012: Remove dependencies of Metrics{Service,Log} on g_browser_process->local_state()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/crashes_ui.cc

Issue 282093012: Remove dependencies of Metrics{Service,Log} on g_browser_process->local_state() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove cruft Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_service_unittest.cc ('K') | « chrome/browser/renderer_host/chrome_render_message_filter.cc ('k') | chrome/browser/ui/webui/flash_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/crashes_ui.cc

diff --git a/chrome/browser/ui/webui/crashes_ui.cc b/chrome/browser/ui/webui/crashes_ui.cc

index b0f745716420bf9ed27cf482070b12bd610ae521..0c4318aa06fb70c72632e9eaec041373b9989671 100644

--- a/chrome/browser/ui/webui/crashes_ui.cc

+++ b/chrome/browser/ui/webui/crashes_ui.cc

@@ -12,6 +12,7 @@

#include "base/memory/ref_counted_memory.h"

#include "base/strings/utf_string_conversions.h"

#include "base/values.h"

+#include "chrome/browser/browser_process.h"

#include "chrome/browser/crash_upload_list.h"

#include "chrome/browser/metrics/metrics_service.h"

#include "chrome/browser/profiles/profile.h"

@@ -151,8 +152,8 @@ void CrashesDOMHandler::OnUploadListAvailable() {

}

void CrashesDOMHandler::UpdateUI() {

- bool crash_reporting_enabled =

- MetricsServiceHelper::IsCrashReportingEnabled();

+ bool crash_reporting_enabled = MetricsServiceHelper::IsCrashReportingEnabled(

+ g_browser_process->local_state());

base::ListValue crash_list;

bool system_crash_reporter = false;