Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 282093009: Emit mementos in crankshaft. (Closed)

Created:
6 years, 7 months ago by mvstanton
Modified:
5 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Emit mementos in crankshaft. Right now, it's controlled by asking an allocation site if it's "undecided" yet. A flag "pretend-pretenuring-uncertainty" can be used to force all allocation sites to masquerade as undecided for testing purposes. Crankshaft mementos can be turned on for: * Array and object literals * Array and object constructor calls (if pretenuring_call_new is turned on) R=hpayer@chromium.org

Patch Set 1 #

Patch Set 2 : Fixed bugs regarding simulates. Added string support. #

Patch Set 3 : Rebased against r21552. #

Patch Set 4 : Bugfix: we didn't ever emit mementos if pre. call new was off. #

Patch Set 5 : Fixes and a test. As it turns out string ops dont work. #

Patch Set 6 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -77 lines) Patch
M src/flag-definitions.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 2 3 4 5 4 chunks +6 lines, -34 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 16 chunks +102 lines, -31 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 4 5 2 chunks +49 lines, -7 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 4 5 2 chunks +16 lines, -4 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 5 1 chunk +58 lines, -0 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Hi Hannes, Here is the change we've discussed. I'll follow up shortly with binary op ...
6 years, 7 months ago (2014-05-16 12:49:21 UTC) #1
mvstanton
(Be sure to get the latest rev if you want to try it out. There ...
6 years, 7 months ago (2014-05-16 16:38:10 UTC) #2
mvstanton
Now with a verifying test. Found out this way that string ops won't work without ...
6 years, 6 months ago (2014-05-28 15:47:29 UTC) #3
mvstanton
Adding Benedikt...
6 years, 6 months ago (2014-06-02 07:03:13 UTC) #4
mvstanton
6 years, 6 months ago (2014-06-04 12:14:29 UTC) #5
Rebased against current tree, allowing experimentation.

Powered by Google App Engine
This is Rietveld 408576698