Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Issue 282093006: [Mac] Unselect generated password when mouse leaves password bounds. (Closed)

Created:
6 years, 7 months ago by Patrick Dubroy
Modified:
6 years, 7 months ago
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org
Visibility:
Public.

Description

[Mac] Unselect generated password when mouse leaves password bounds. In the Mac implementation of the password generation poup, the password row is not unselected when the mouse is moved elsewhere in the popup (e.g. over top of the help text). The fix is that PasswordSelected() should always be called in SetSelectionAtPoint, not just when the mouse is within the password bounds. The Views implementation happens to work because it has a subview (PasswordRow) which triggers OnMouseExited() when the mouse moves outside of the password bounds. Also added an optimization that PasswordSelectionUpdated() is only called when the value is actually changed, not every time PasswordSelected() is called. BUG=114092 R=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Patrick Dubroy
Garrett, Ilya, PTAL.
6 years, 7 months ago (2014-05-15 11:25:21 UTC) #1
Ilya Sherman
LGTM
6 years, 7 months ago (2014-05-15 20:23:11 UTC) #2
Patrick Dubroy
Committed patchset #1 manually as r270975 (presubmit successful).
6 years, 7 months ago (2014-05-16 10:00:58 UTC) #3
Adrian Kuegel
A revert of this CL has been created in https://codereview.chromium.org/287063007/ by akuegel@chromium.org. The reason for ...
6 years, 7 months ago (2014-05-16 12:21:33 UTC) #4
Adrian Kuegel
6 years, 7 months ago (2014-05-16 12:33:52 UTC) #5
Message was sent while issue was closed.
On 2014/05/16 12:21:33, Adrian Kuegel wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/287063007/ by mailto:akuegel@chromium.org.
> 
> The reason for reverting is: Speculative revert, FormFillLatencyAfterSubmit is
> failing.

Feel free to reland this. Apparently it was a flaky test, sorry for reverting.

Powered by Google App Engine
This is Rietveld 408576698