Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: pkg/analysis_server/test/integration/analysis/error_test.dart

Issue 2820893002: Make the analysis server integration tests driver only. (Closed)
Patch Set: uncomment test code Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/analysis/error_test.dart
diff --git a/pkg/analysis_server/test/integration/analysis/error_test.dart b/pkg/analysis_server/test/integration/analysis/error_test.dart
index 2de9b7499206489edd17e56e33440c94b81d6997..8920f3ec3fa36aeed8139509e632647eac65e164 100644
--- a/pkg/analysis_server/test/integration/analysis/error_test.dart
+++ b/pkg/analysis_server/test/integration/analysis/error_test.dart
@@ -14,7 +14,8 @@ main() {
});
}
-class AbstractAnalysisErrorIntegrationTest
+@reflectiveTest
+class AnalysisErrorIntegrationTest
extends AbstractAnalysisServerIntegrationTest {
test_detect_simple_error() {
String pathname = sourcePath('test.dart');
@@ -67,7 +68,15 @@ abstract class C extends B {
"The class 'C' can't be used as a mixin because it references 'super'."));
}
+ @failingTest
test_super_mixins_enabled() async {
+ // We see errors here with the new driver (#28870).
+ // Expected: empty
+ // Actual: [
+ // AnalysisError:{"severity":"ERROR","type":"COMPILE_TIME_ERROR","location":{"file":"/var/folders/00/0w95r000h01000cxqpysvccm003j4q/T/analysisServerfbuOQb/test.dart","offset":31,"length":1,"startLine":1,"startColumn":32},"message":"The class 'C' can't be used as a mixin because it extends a class other than Object.","correction":"","code":"mixin_inherits_from_not_object","hasFix":false},
+ // AnalysisError:{"severity":"ERROR","type":"COMPILE_TIME_ERROR","location":{"file":"/var/folders/00/0w95r000h01000cxqpysvccm003j4q/T/analysisServerfbuOQb/test.dart","offset":31,"length":1,"startLine":1,"startColumn":32},"message":"The class 'C' can't be used as a mixin because it references 'super'.","correction":"","code":"mixin_references_super","hasFix":false}
+ // ]
+
String pathname = sourcePath('test.dart');
writeFile(
pathname,
@@ -94,7 +103,3 @@ abstract class C extends B {
expect(errors, isEmpty);
}
}
-
-@reflectiveTest
-class AnalysisErrorIntegrationTest
- extends AbstractAnalysisErrorIntegrationTest {}

Powered by Google App Engine
This is Rietveld 408576698