Remove unused WebTestProxy paint/canvas code

Remove unused WebTestProxy paint/canvas code

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271180

[enne (OOO), 2014-05-14 23:09:17]

Depends on https://codereview.chromium.org/284073002/ and
https://codereview.chromium.org/289873002/.

[danakj, 2014-05-15 14:34:33]

LGTM

https://codereview.chromium.org/282083003/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/web_test_proxy.cc (right):

https://codereview.chromium.org/282083003/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/web_test_proxy.cc:428: int pageCount =
webFrame->printBegin(pageSizeInPixels);
page_count, etc. if is_opaque is going to be chrome style (I approve) let's fix
everything in this method now

https://codereview.chromium.org/282083003/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/web_test_proxy.cc:434: if (canvas.get())
nit: no .get() needed

https://codereview.chromium.org/282083003/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/web_test_proxy.cc:439: SkBaseDevice* device =
skia::GetTopDevice(*canvas.get());
nit: no .get() needed

https://codereview.chromium.org/282083003/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/web_test_proxy.cc:495: void
WebTestProxyBase::ScheduleComposite() {
If this does nothing can it go away?

[enne (OOO), 2014-05-15 17:10:33]

abarth: content/shell/renderer/test_runner/
sky: content/test/

https://codereview.chromium.org/282083003/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/web_test_proxy.cc (right):

https://codereview.chromium.org/282083003/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/web_test_proxy.cc:428: int pageCount =
webFrame->printBegin(pageSizeInPixels);
On 2014/05/15 14:34:33, danakj wrote:
> page_count, etc. if is_opaque is going to be chrome style (I approve) let's
fix
> everything in this method now

How about I just fix up this whole file afterwards?

https://codereview.chromium.org/282083003/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/web_test_proxy.cc:434: if (canvas.get())
On 2014/05/15 14:34:33, danakj wrote:
> nit: no .get() needed

Done.

https://codereview.chromium.org/282083003/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/web_test_proxy.cc:439: SkBaseDevice* device =
skia::GetTopDevice(*canvas.get());
On 2014/05/15 14:34:33, danakj wrote:
> nit: no .get() needed

Done.

[danakj, 2014-05-15 17:11:02]

https://codereview.chromium.org/282083003/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/web_test_proxy.cc (right):

https://codereview.chromium.org/282083003/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/web_test_proxy.cc:428: int pageCount =
webFrame->printBegin(pageSizeInPixels);
On 2014/05/15 17:10:33, enne wrote:
> On 2014/05/15 14:34:33, danakj wrote:
> > page_count, etc. if is_opaque is going to be chrome style (I approve) let's
> fix
> > everything in this method now
> 
> How about I just fix up this whole file afterwards?

Yes, please. :)

[sky, 2014-05-15 19:18:14]

LGTM

[enne (OOO), 2014-05-16 18:42:40]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-05-16 18:43:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/282083003/40001

[enne (OOO), 2014-05-16 19:04:34]

+dpranke for content/shell/renderer/test_runner OWNERS

[Dirk Pranke, 2014-05-16 19:40:05]

rubber-stamp lgtm.

[commit-bot: I haz the power, 2014-05-17 05:56:29]

Change committed as 271180