Add associated interfaces & bindings.

mojo/public/tools/bindings/pylib/mojom/generate/module.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This module's classes provide an interface to mojo modules. Modules are
 # collections of interfaces and structs to be used by mojo ipc clients and
 # servers.
 #
 # A simple interface would be created this way:
 # module = mojom.generate.module.Module('Foo')
@@ skipping 798 matching lines @@
 
 def HasCallbacks(interface):
   for method in interface.methods:
     if method.response_parameters != None:
       return True
   return False
 
 
 # Finds out whether an interface passes associated interfaces and associated
 # interface requests.
 def PassesAssociatedKinds(interface):

[yzshen1, 2017/04/19 21:11:34]

This function should be able to call MethodPassesAsosciatedKinds, right?

[wangjimmy, 2017/04/20 15:36:44]

Done.

   def _ContainsAssociatedKinds(kind, visited_kinds):
     if kind in visited_kinds:
       # No need to examine the kind again.
       return False
     visited_kinds.add(kind)
     if IsAssociatedKind(kind):
       return True
     if IsArrayKind(kind):
       return _ContainsAssociatedKinds(kind.kind, visited_kinds)
     if IsStructKind(kind) or IsUnionKind(kind):
       for field in kind.fields:
         if _ContainsAssociatedKinds(field.kind, visited_kinds):
           return True
     if IsMapKind(kind):
       # No need to examine the key kind, only primitive kinds and non-nullable
       # string are allowed to be key kinds.
       return _ContainsAssociatedKinds(kind.value_kind, visited_kinds)
     return False
 
   visited_kinds = set()
   for method in interface.methods:
     for param in method.parameters:
       if _ContainsAssociatedKinds(param.kind, visited_kinds):
         return True
     if method.response_parameters != None:
       for param in method.response_parameters:
         if _ContainsAssociatedKinds(param.kind, visited_kinds):
           return True
   return False
 

[yzshen1, 2017/04/19 21:11:34]

I understand some files don't respect this, but we are supposed to use two empty
lines according to python style guide.
"Two blank lines between top-level definitions, one blank line between method
definitions."

[wangjimmy, 2017/04/20 15:36:44]

Done.

+# Finds out whether a method passes associated interfaces and associated
+# interface requests.
+def MethodPassesAssociatedKinds(method):
+  def _ContainsAssociatedKinds(kind, visited_kinds):
+    if kind in visited_kinds:
+      # No need to examine the kind again.
+      return False
+    visited_kinds.add(kind)
+    if IsAssociatedKind(kind):
+      return True
+    if IsArrayKind(kind):
+      return _ContainsAssociatedKinds(kind.kind, visited_kinds)
+    if IsStructKind(kind) or IsUnionKind(kind):
+      for field in kind.fields:
+        if _ContainsAssociatedKinds(field.kind, visited_kinds):
+          return True
+    if IsMapKind(kind):
+      # No need to examine the key kind, only primitive kinds and non-nullable
+      # string are allowed to be key kinds.
+      return _ContainsAssociatedKinds(kind.value_kind, visited_kinds)
+    return False
+
+  visited_kinds = set()
+  for param in method.parameters:
+    if _ContainsAssociatedKinds(param.kind, visited_kinds):
+      return True
+  if method.response_parameters != None:
+    for param in method.response_parameters:
+      if _ContainsAssociatedKinds(param.kind, visited_kinds):
+        return True
+  return False
 
 def HasSyncMethods(interface):
   for method in interface.methods:
     if method.sync:
       return True
   return False
 
 
 def ContainsHandlesOrInterfaces(kind):
   """Check if the kind contains any handles.
@@ skipping 22 matching lines @@
       return True
     elif IsAnyInterfaceKind(kind):
       return True
     elif IsArrayKind(kind):
       return Check(kind.kind)
     elif IsMapKind(kind):
       return Check(kind.key_kind) or Check(kind.value_kind)
     else:
       return False
   return Check(kind)