Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

Issue 2820743003: Paint text underline/overline decorations before painting text. (Closed)
Patch Set: Sync to head. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h
diff --git a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h
index f2092ebaafefd8ed29b5c3ee0620f29cb60f582c..b6560c13e484d5d47e5364fd78f49528b1e323ad 100644
--- a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h
+++ b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h
@@ -13,7 +13,6 @@ namespace blink {
struct PaintInfo;
-class AppliedTextDecoration;
class Color;
class CompositionUnderline;
class ComputedStyle;
@@ -24,7 +23,6 @@ class InlineTextBox;
class LayoutObject;
class LayoutPoint;
class LayoutTextCombine;
-class TextPainter;
enum class DocumentMarkerPaintPhase { kForeground, kBackground };
@@ -82,10 +80,7 @@ class InlineTextBoxPainter {
const Font&,
Color text_color,
LayoutTextCombine* = nullptr);
- void PaintDecorations(TextPainter&,
- const PaintInfo&,
- const LayoutPoint& box_origin,
- const Vector<AppliedTextDecoration>&);
+
void PaintCompositionUnderline(GraphicsContext&,
const LayoutPoint& box_origin,
const CompositionUnderline&);

Powered by Google App Engine
This is Rietveld 408576698