shelf: Allow dragging items from main shelf to overflow shelf.

ash/shelf/shelf_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SHELF_SHELF_VIEW_H_
 #define ASH_SHELF_SHELF_VIEW_H_
 
 #include <memory>
 #include <string>
 #include <utility>
@@ skipping 437 matching lines @@
 
   // The rip off view when a snap back operation is underway.
   views::View* snap_back_from_rip_off_view_;
 
   // True when this ShelfView is used for Overflow Bubble.
   bool overflow_mode_;
 
   // Holds a pointer to main ShelfView when a ShelfView is in overflow mode.
   ShelfView* main_shelf_;
 
-  // True when ripped item from overflow bubble is entered into Shelf.
-  bool dragged_off_from_overflow_to_shelf_;
+  // True when ripped item from overflow bubble is entered into Shelf or vice

[msw, 2017/04/17 19:29:09]

nit: // True when an item is dragged from one shelf to another (eg. overflow).

[sammiequon, 2017/04/17 23:42:29]

Done.

+  // versa.
+  bool dragged_off_from_shelf_to_other_shelf_;

[msw, 2017/04/17 19:29:09]

This name is pretty bad; how about moving this just below |dragged_off_shelf_|
and using the name |dragged_to_another_shelf_| or |dragged_from_another_shelf_|
or similar?

[sammiequon, 2017/04/17 23:42:29]

Done.

 
   // True if the event is a repost event from a event which has just closed the
   // menu of the same shelf item.
   bool is_repost_event_on_same_item_;
 
   // Record the index for the last pressed shelf item. This variable is used to
   // check if a repost event occurs on the same shelf item as previous one. If
   // so, the repost event should be ignored.
   int last_pressed_index_;
 
   // Tracks UMA metrics based on shelf button press actions.
   ShelfButtonPressedMetricTracker shelf_button_pressed_metric_tracker_;
 
   base::WeakPtrFactory<ShelfView> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ShelfView);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SHELF_SHELF_VIEW_H_