Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1944)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2820643002: Decouple some graphics-related IsLowEndDevice() policies for 1GB devices. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 7d6113cf65bf6f2f7270097e668eff44b6c7feb7..b8c4c05a75f36d8c8ec03a32b9ea652a9bbdd363 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1037,15 +1037,13 @@ void RenderView::ApplyWebPreferences(const WebPreferences& prefs,
settings->SetPreferHiddenVolumeControls(true);
settings->SetSpellCheckEnabledByDefault(prefs.spellcheck_enabled_by_default);
- // Force preload=none and disable autoplay on older or low end Android
+ // Force preload=none and disable autoplay on older Android
// platforms because their media pipelines are not stable enough to handle
// concurrent elements. See http://crbug.com/612909, http://crbug.com/622826.
- const bool is_low_end_device =
+ const bool is_jelly_bean =
base::android::BuildInfo::GetInstance()->sdk_int() <=
- base::android::SDK_VERSION_JELLY_BEAN_MR2 ||
- base::SysInfo::IsLowEndDevice();
- // TODO(mlamouri): rename this setting "isLowEndDevice".
- settings->SetForcePreloadNoneForMediaElements(is_low_end_device);
+ base::android::SDK_VERSION_JELLY_BEAN_MR2;
+ settings->SetForcePreloadNoneForMediaElements(is_jelly_bean);
WebRuntimeFeatures::EnableVideoFullscreenOrientationLock(
prefs.video_fullscreen_orientation_lock_enabled);
« no previous file with comments | « content/renderer/media/renderer_webmediaplayer_delegate.cc ('k') | media/gpu/android_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698