Decouple some graphics-related IsLowEndDevice() policies for 1GB devices.

content/renderer/media/renderer_webmediaplayer_delegate.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/renderer_webmediaplayer_delegate.h"
 
 #include <stdint.h>
 
 #include "base/auto_reset.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 20 matching lines @@
 namespace media {
 
 RendererWebMediaPlayerDelegate::RendererWebMediaPlayerDelegate(
     content::RenderFrame* render_frame)
     : RenderFrameObserver(render_frame),
       default_tick_clock_(new base::DefaultTickClock()),
       tick_clock_(default_tick_clock_.get()) {
   idle_cleanup_interval_ = base::TimeDelta::FromSeconds(5);
   idle_timeout_ = base::TimeDelta::FromSeconds(15);
 
-  // Idle players time out more aggressively on low end devices.
-  is_low_end_device_ = base::SysInfo::IsLowEndDevice();
+  is_jelly_bean_ = false;
 
 #if defined(OS_ANDROID)
   // On Android, due to the instability of the OS level media components, we
-  // consider all pre-KitKat devices to be low end.
-  is_low_end_device_ |=
-      base::android::BuildInfo::GetInstance()->sdk_int() <= 18;
+  // consider all pre-KitKat devices to be potentially buggy.
+  is_jelly_bean_ |= base::android::BuildInfo::GetInstance()->sdk_int() <= 18;
 #endif
 }
 
 RendererWebMediaPlayerDelegate::~RendererWebMediaPlayerDelegate() {}
 
 bool RendererWebMediaPlayerDelegate::IsFrameHidden() {
   if (is_frame_hidden_for_testing_)
     return true;
 
   return (render_frame() && render_frame()->IsHidden()) || is_frame_closed_;
@@ skipping 143 matching lines @@
     IPC_MESSAGE_HANDLER(MediaPlayerDelegateMsg_BecamePersistentVideo,
                         OnMediaDelegateBecamePersistentVideo)
     IPC_MESSAGE_UNHANDLED(return false)
   IPC_END_MESSAGE_MAP()
   return true;
 }
 
 void RendererWebMediaPlayerDelegate::SetIdleCleanupParamsForTesting(
     base::TimeDelta idle_timeout,
     base::TickClock* tick_clock,
-    bool is_low_end_device) {
+    bool is_jelly_bean) {
   idle_cleanup_interval_ = base::TimeDelta();
   idle_timeout_ = idle_timeout;
   tick_clock_ = tick_clock;
-  is_low_end_device_ = is_low_end_device;
+  is_jelly_bean_ = is_jelly_bean;
 }
 
 bool RendererWebMediaPlayerDelegate::IsIdleCleanupTimerRunningForTesting()
     const {
   return idle_cleanup_timer_.IsRunning();
 }
 
 void RendererWebMediaPlayerDelegate::SetFrameHiddenForTesting(bool is_hidden) {
   if (is_hidden == is_frame_hidden_for_testing_)
     return;
@@ skipping 77 matching lines @@
 
   // Record UMAs for background video playback.
   RecordBackgroundVideoPlayback();
 
   // Clean up idle players.
   bool aggressive_cleanup = false;
 
   // When we reach the maximum number of idle players, clean them up
   // aggressively. Values chosen after testing on a Galaxy Nexus device for
   // http://crbug.com/612909.
-  if (idle_player_map_.size() > (is_low_end_device_ ? 2u : 8u))
+  if (idle_player_map_.size() > (is_jelly_bean_ ? 2u : 8u))
     aggressive_cleanup = true;
 
-  // When a player plays on a low-end device, clean up idle players
+  // When a player plays on a buggy old device, clean up idle players
   // aggressively.
-  if (has_played_video_since_last_update_task && is_low_end_device_)
+  if (has_played_video_since_last_update_task && is_jelly_bean_)
     aggressive_cleanup = true;
 
   CleanUpIdlePlayers(aggressive_cleanup ? base::TimeDelta() : idle_timeout_);
 
   // If there are still idle players, schedule an attempt to clean them up.
   // This construct ensures that the next callback is always
   // |idle_cleanup_interval_| from now.
   idle_cleanup_timer_.Stop();
   if (!idle_player_map_.empty()) {
     idle_cleanup_timer_.Start(
@@ skipping 48 matching lines @@
       player->OnIdleTimeout();
     }
   }
 }
 
 void RendererWebMediaPlayerDelegate::OnDestruct() {
   delete this;
 }
 
 }  // namespace media