third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h - Issue 2820633002: [DMC #2] Add DocumentMarkerList interface and GenericDocumentMarkerListImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Issue 2820633002: [DMC #2] Add DocumentMarkerList interface and GenericDocumentMarkerListImpl (Closed)

Patch Set: Fix nit Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/BUILD.gn ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

index 817da462c7187195598de7928e056f990560b7e8..e367111ab43022717793fc3802096bdaa66b35d4 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

@@ -40,6 +40,7 @@

namespace blink {

+class DocumentMarkerList;

class Node;

class RenderedDocumentMarker;

@@ -111,12 +112,11 @@ class CORE_EXPORT DocumentMarkerController final

private:

void AddMarker(Node*, DocumentMarker*);

- using MarkerList = HeapVector<Member<RenderedDocumentMarker>>;

- using MarkerLists =

- HeapVector<Member<MarkerList>, DocumentMarker::kMarkerTypeIndexesCount>;

+ using MarkerLists = HeapVector<Member<DocumentMarkerList>,

+ DocumentMarker::kMarkerTypeIndexesCount>;

using MarkerMap = HeapHashMap<WeakMember<const Node>, Member<MarkerLists>>;

- static Member<MarkerList>& ListForType(MarkerLists*,

- DocumentMarker::MarkerType);

+ static Member<DocumentMarkerList>& ListForType(MarkerLists*,

+ DocumentMarker::MarkerType);

bool PossiblyHasMarkers(DocumentMarker::MarkerTypes);

void RemoveMarkersFromList(MarkerMap::iterator, DocumentMarker::MarkerTypes);

void RemoveMarkers(TextIterator&, DocumentMarker::MarkerTypes);