[DMC #2] Add DocumentMarkerList interface and GenericDocumentMarkerListImpl

third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h

Index: third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h
diff --git a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h
new file mode 100644
index 0000000000000000000000000000000000000000..12dda7734a22e05b4499cb704ffb2f5bc5a4aa3b
--- /dev/null
+++ b/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h
@@ -0,0 +1,43 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef GenericDocumentMarkerListImpl_h
+#define GenericDocumentMarkerListImpl_h
+
+#include "core/editing/markers/DocumentMarkerList.h"
+
+namespace blink {
+
+class RenderedDocumentMarker;
+
+class GenericDocumentMarkerListImpl : public DocumentMarkerList {

[yosin_UTC9, 2017/04/25 08:20:59]

- Could you mark GenericDocumentMarkerListImpl as "final"?
- Could you add short description of this interface to follow [1]?


[1] http://dev.chromium.org/blink/coding-style#TOC-Documentation
...
2. Classes should have a class-level comment.
...

+ public:
+  GenericDocumentMarkerListImpl() = default;
+
+  bool IsEmpty() const final;

[yosin_UTC9, 2017/04/25 08:20:59]

Could you add comment like below to indicate following members implement
DocumentMarkerList interface?

// Implement DocumentMarkerList members
(or whatever)

+
+  void Add(DocumentMarker*) final;
+  void Clear() final;
+
+  const HeapVector<Member<RenderedDocumentMarker>>& GetMarkers() const final;
+
+  bool MoveMarkers(int length, DocumentMarkerList* dst_list) final;
+  bool RemoveMarkers(unsigned start_offset, int length) final;
+  bool RemoveMarkersUnderWords(const String& node_text,
+                               const Vector<String>& words) final;
+  bool ShiftMarkers(unsigned offset,
+                    unsigned old_length,
+                    unsigned new_length) final;
+
+  DECLARE_TRACE();
+
+ private:
+  HeapVector<Member<RenderedDocumentMarker>> markers_;
+
+  DISALLOW_COPY_AND_ASSIGN(GenericDocumentMarkerListImpl);
+};
+
+}  // namespace blink
+
+#endif  // GenericDocumentMarkerListImpl_h