third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp - Issue 2820633002: [DMC #2] Add DocumentMarkerList interface and GenericDocumentMarkerListImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp

Issue 2820633002: [DMC #2] Add DocumentMarkerList interface and GenericDocumentMarkerListImpl (Closed)

Patch Set: Change AppendMarkersToInputList() to GetMarkers() Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('K') | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h ('k') | third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp

index 9783b202556db6a77f7f22d30cad65c8fb7d3898..c65ed4c684c7e5d6359e3a67a71c392997edb8e7 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp

@@ -40,7 +40,7 @@ void DocumentMarkerListEditor::AddMarker(MarkerList* list,

bool DocumentMarkerListEditor::MoveMarkers(MarkerList* src_list,

int length,

- MarkerList* dst_list) {

+ DocumentMarkerList* dst_list) {

DCHECK_GT(length, 0);

bool didMoveMarker = false;

unsigned end_offset = length - 1;

@@ -55,7 +55,7 @@ bool DocumentMarkerListEditor::MoveMarkers(MarkerList* src_list,

if (marker.EndOffset() > end_offset)

marker.SetEndOffset(end_offset);

- DocumentMarkerListEditor::AddMarker(dst_list, &marker);

+ dst_list->Add(&marker);

didMoveMarker = true;

}