[DMC #2] Add DocumentMarkerList interface and GenericDocumentMarkerListImpl

third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef DocumentMarkerList_h
+#define DocumentMarkerList_h
+
+#include "core/CoreExport.h"
+#include "platform/heap/Handle.h"
+
+namespace blink {
+
+class DocumentMarker;
+class RenderedDocumentMarker;
+
+class CORE_EXPORT DocumentMarkerList
+    : public GarbageCollectedFinalized<DocumentMarkerList> {
+ public:
+  DocumentMarkerList();
+
+  virtual ~DocumentMarkerList();
+
+  virtual bool IsEmpty() const = 0;
+
+  virtual void Add(DocumentMarker*) = 0;
+  virtual void Clear() = 0;
+
+  virtual const HeapVector<Member<RenderedDocumentMarker>>& GetMarkers()
+      const = 0;
+
+  // Returns true if at least one marker is copied, false otherwise
+  virtual bool MoveMarkers(int length, DocumentMarkerList* dst_list) = 0;
+
+  // Returns true if at least one marker is removed, false otherwise
+  virtual bool RemoveMarkers(unsigned start_offset, int length) = 0;
+
+  // Returns true if a marker was removed, false otherwise.
+  virtual bool RemoveMarkersUnderWords(const String& node_text,

[yosin_UTC9, 2017/04/24 04:18:56]

We don't need to have |RemoveMarkersUnderWords()| in DMList interface,
since it is only for spelling marker.

GenericDMListImpl or DMListEditor should have RemoveSpellingMarkersUnderWords().
Then we'll move it to SpellingMarkerListImpl.

[Xiaocheng, 2017/04/24 15:13:33]

In the design that we agreed, DMLEditor is for code sharing between different
list impls, so there's no need to put a function in DMLEditor if only one impl
uses it.

I think the only question is whether we want to keep this function in the
interface, or keep it only in SpellCheckListImpl and use it with downcast.

I prefer the latter. Adding a TODO for moving this function from the DML
interface to SpellCheckListImpl looks fine to me.

+                                       const Vector<String>& words) = 0;
+
+  // Returns true if at least one marker is shifted or removed, false otherwise
+  virtual bool ShiftMarkers(unsigned offset,
+                            unsigned old_length,
+                            unsigned new_length) = 0;
+
+  DEFINE_INLINE_VIRTUAL_TRACE() {}
+  DISALLOW_COPY_AND_ASSIGN(DocumentMarkerList);
+};
+
+}  // namespace blink
+
+#endif  // DocumentMarkerList_h