Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: remoting/client/server_log_entry_client_unittest.cc

Issue 282063005: Pull out common code from client and host versions of ServerLogEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/server_log_entry_client_unittest.cc
diff --git a/remoting/client/server_log_entry_client_unittest.cc b/remoting/client/server_log_entry_client_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..73a5faf74f08705b4feb36bc3782eccf808ee15e
--- /dev/null
+++ b/remoting/client/server_log_entry_client_unittest.cc
@@ -0,0 +1,127 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/memory/scoped_ptr.h"
+#include "base/strings/stringize_macros.h"
+#include "base/sys_info.h"
+#include "remoting/client/chromoting_stats.h"
+#include "remoting/client/server_log_entry_client.h"
+#include "remoting/protocol/server_log_entry.h"
+#include "remoting/protocol/server_log_entry_unittest.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/libjingle/source/talk/xmllite/xmlelement.h"
+
+using base::SysInfo;
+using buzz::XmlAttr;
+using buzz::XmlElement;
+using remoting::protocol::ConnectionToHost;
+using remoting::protocol::ServerLogEntry;
+using remoting::protocol::VerifyStanza;
+
+namespace remoting {
+
+TEST(ServerLogEntryClientTest, SessionStateChange) {
+ scoped_ptr<ServerLogEntry> entry(MakeLogEntryForSessionStateChange(
+ ConnectionToHost::CONNECTED, remoting::protocol::OK));
+ scoped_ptr<XmlElement> stanza = entry->ToStanza();
+ std::string error;
+ std::map<std::string, std::string> key_value_pairs;
+ key_value_pairs["role"] = "client";
+ key_value_pairs["event-name"] = "session-state";
+ key_value_pairs["session-state"] = "connected";
+ std::set<std::string> keys;
+ ASSERT_TRUE(VerifyStanza(key_value_pairs, keys, stanza.get(), &error))
+ << error;
+}
+
+TEST(ServerLogEntryClientTest, SessionStateChangeWithError) {
+ scoped_ptr<ServerLogEntry> entry(MakeLogEntryForSessionStateChange(
+ ConnectionToHost::FAILED, remoting::protocol::PEER_IS_OFFLINE));
+ scoped_ptr<XmlElement> stanza = entry->ToStanza();
+ std::string error;
+ std::map<std::string, std::string> key_value_pairs;
+ key_value_pairs["role"] = "client";
+ key_value_pairs["event-name"] = "session-state";
+ key_value_pairs["session-state"] = "connection-failed";
+ key_value_pairs["connection-error"] = "host-is-offline";
+ std::set<std::string> keys;
+ ASSERT_TRUE(VerifyStanza(key_value_pairs, keys, stanza.get(), &error))
+ << error;
+}
+
+TEST(ServerLogEntryClientTest, Statistics) {
+ ChromotingStats statistics;
+ scoped_ptr<ServerLogEntry> entry(MakeLogEntryForStatistics(&statistics));
+ scoped_ptr<XmlElement> stanza = entry->ToStanza();
+ std::string error;
+ std::map<std::string, std::string> key_value_pairs;
+ key_value_pairs["role"] = "client";
+ key_value_pairs["event-name"] = "connection-statistics";
+ std::set<std::string> keys;
+ keys.insert("video-bandwidth");
+ keys.insert("capture-latency");
+ keys.insert("encode-latency");
+ keys.insert("decode-latency");
+ keys.insert("render-latency");
+ keys.insert("roundtrip-latency");
+ ASSERT_TRUE(VerifyStanza(key_value_pairs, keys, stanza.get(), &error))
+ << error;
+}
+
+TEST(ServerLogEntryClientTest, SessionIdChanged) {
+ scoped_ptr<ServerLogEntry> entry(MakeLogEntryForSessionIdOld("abc"));
+ scoped_ptr<XmlElement> stanza = entry->ToStanza();
+ std::string error;
+ std::map<std::string, std::string> key_value_pairs;
+ key_value_pairs["role"] = "client";
+ key_value_pairs["event-name"] = "session-id-old";
+ key_value_pairs["session-id"] = "abc";
+ std::set<std::string> keys;
+ ASSERT_TRUE(VerifyStanza(key_value_pairs, keys, stanza.get(), &error))
+ << error;
+
+ entry = MakeLogEntryForSessionIdNew("def");
+ stanza = entry->ToStanza();
+ key_value_pairs["event-name"] = "session-id-new";
+ key_value_pairs["session-id"] = "def";
+ ASSERT_TRUE(VerifyStanza(key_value_pairs, keys, stanza.get(), &error))
+ << error;
+}
+
+TEST(ServerLogEntryClientTest, AddClientFields) {
+ scoped_ptr<ServerLogEntry> entry(MakeLogEntryForSessionStateChange(
+ ConnectionToHost::CONNECTED, remoting::protocol::OK));
+ AddClientFieldsToLogEntry(entry.get());
+ scoped_ptr<XmlElement> stanza = entry->ToStanza();
+ std::string error;
+ std::map<std::string, std::string> key_value_pairs;
+ key_value_pairs["role"] = "client";
+ key_value_pairs["event-name"] = "session-state";
+ key_value_pairs["session-state"] = "connected";
+ key_value_pairs["os-name"] = SysInfo::OperatingSystemName();
+ key_value_pairs["os-version"] = SysInfo::OperatingSystemVersion();
+ key_value_pairs["app-version"] = STRINGIZE(VERSION);
+ key_value_pairs["cpu"] = SysInfo::OperatingSystemArchitecture();
+ std::set<std::string> keys;
+ ASSERT_TRUE(VerifyStanza(key_value_pairs, keys, stanza.get(), &error)) <<
+ error;
+}
+
+TEST(ServerLogEntryClientTest, AddSessionDuration) {
+ scoped_ptr<ServerLogEntry> entry(MakeLogEntryForSessionStateChange(
+ ConnectionToHost::CONNECTED, remoting::protocol::OK));
+ AddSessionDurationToLogEntry(entry.get(), base::TimeDelta::FromSeconds(123));
+ scoped_ptr<XmlElement> stanza = entry->ToStanza();
+ std::string error;
+ std::map<std::string, std::string> key_value_pairs;
+ key_value_pairs["role"] = "client";
+ key_value_pairs["event-name"] = "session-state";
+ key_value_pairs["session-state"] = "connected";
+ key_value_pairs["session-duration"] = "123";
+ std::set<std::string> keys;
+ ASSERT_TRUE(VerifyStanza(key_value_pairs, keys, stanza.get(), &error))
+ << error;
+}
+
+} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698