Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: remoting/client/server_log_entry_client.h

Issue 282063005: Pull out common code from client and host versions of ServerLogEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef REMOTING_CLIENT_SERVER_LOG_ENTRY_CLIENT_H_
6 #define REMOTING_CLIENT_SERVER_LOG_ENTRY_CLIENT_H_
7
8 #include "base/time/time.h"
9 #include "remoting/protocol/connection_to_host.h"
10 #include "remoting/protocol/errors.h"
11
12 namespace remoting {
13
14 class ChromotingStats;
15
16 namespace protocol {
17 class ServerLogEntry;
18 } // namespace protocol
19
20 // Constructs a log entry for a session state change.
rmsousa 2014/05/20 00:54:41 Nit: I think you could inherit from ServerLogEntry
Lambros 2014/05/20 01:13:35 I thought about that, but I'm not sure. The proble
21 scoped_ptr<protocol::ServerLogEntry> MakeLogEntryForSessionStateChange(
22 protocol::ConnectionToHost::State state,
23 protocol::ErrorCode error);
24
25 // Constructs a log entry for reporting statistics.
26 scoped_ptr<protocol::ServerLogEntry> MakeLogEntryForStatistics(
27 ChromotingStats* statistics);
28
29 // Constructs a log entry for reporting session ID is old.
30 scoped_ptr<protocol::ServerLogEntry> MakeLogEntryForSessionIdOld(
31 const std::string& session_id);
32
33 // Constructs a log entry for reporting session ID is old.
34 scoped_ptr<protocol::ServerLogEntry> MakeLogEntryForSessionIdNew(
35 const std::string& session_id);
36
37 void AddClientFieldsToLogEntry(protocol::ServerLogEntry* entry);
38 void AddSessionIdToLogEntry(protocol::ServerLogEntry* entry,
39 const std::string& id);
40 void AddSessionDurationToLogEntry(protocol::ServerLogEntry* entry,
41 base::TimeDelta duration);
42
43 } // namespace remoting
44
45 #endif // REMOTING_CLIENT_SERVER_LOG_ENTRY_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698