Fix handling of null pointers in JS bindings.

Fix handling of null pointers in JS bindings.

This allows passing of arbitrary length list-like structures across the
a message pipe. This is a pre-requisite for passing corrupt, circular, or
otherwise malformed list-like structures across a message pipe for testing.

Also fix excessive indentation in one place in js_to_cpp_unittest.cc
(leading to larger diff). Sorry.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271173

[Tom Sepez, 2014-05-16 18:14:22]

Matt, please review. Thanks.

[Matt Perry, 2014-05-16 18:39:04]

lgtm

https://codereview.chromium.org/282063003/diff/1/mojo/apps/js/test/js_to_cpp_...
File mojo/apps/js/test/js_to_cpp_unittest.js (right):

https://codereview.chromium.org/282063003/diff/1/mojo/apps/js/test/js_to_cpp_...
mojo/apps/js/test/js_to_cpp_unittest.js:38: var list;
this looks unused

https://codereview.chromium.org/282063003/diff/1/mojo/apps/js/test/js_to_cpp_...
mojo/apps/js/test/js_to_cpp_unittest.js:76: var list = new
jsToCpp.EchoArgsList();
use a different variable name - this one shadows the param name

https://codereview.chromium.org/282063003/diff/1/mojo/public/js/bindings/code...
File mojo/public/js/bindings/codec.js (right):

https://codereview.chromium.org/282063003/diff/1/mojo/public/js/bindings/code...
mojo/public/js/bindings/codec.js:240: }
I assume this mimics how its done on the C++ side?

[Tom Sepez, 2014-05-16 18:56:17]

https://codereview.chromium.org/282063003/diff/1/mojo/public/js/bindings/code...
File mojo/public/js/bindings/codec.js (right):

https://codereview.chromium.org/282063003/diff/1/mojo/public/js/bindings/code...
mojo/public/js/bindings/codec.js:240: }
On 2014/05/16 18:39:04, Matt Perry wrote:
> I assume this mimics how its done on the C++ side?
It's not exactly analogous, because JS has to decode everything, but C only has
to decode pointers and handles. SO on the C side, the checks are in the decode
templates for the cases where it matter.

[Tom Sepez, 2014-05-16 18:57:17]

https://codereview.chromium.org/282063003/diff/1/mojo/apps/js/test/js_to_cpp_...
File mojo/apps/js/test/js_to_cpp_unittest.js (right):

https://codereview.chromium.org/282063003/diff/1/mojo/apps/js/test/js_to_cpp_...
mojo/apps/js/test/js_to_cpp_unittest.js:76: var list = new
jsToCpp.EchoArgsList();
On 2014/05/16 18:39:04, Matt Perry wrote:
> use a different variable name - this one shadows the param name
Yeah, I noticed this soon after posting this. Done.

[Tom Sepez, 2014-05-16 19:00:51]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2014-05-16 19:01:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tsepez@chromium.org/282063003/20001

[Tom Sepez, 2014-05-16 19:57:00]

+sky for OWNERS review. Thanks.

[darin (slow to review), 2014-05-16 20:06:41]

LGTM deferring to mpcomplete.  I need to add him to the OWNERS file!

[Tom Sepez, 2014-05-16 20:07:31]

Thanks Darin, dropping sky.

[Tom Sepez, 2014-05-16 20:07:44]

The CQ bit was unchecked by tsepez@chromium.org

[Tom Sepez, 2014-05-16 20:07:50]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2014-05-16 20:08:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tsepez@chromium.org/282063003/20001

[commit-bot: I haz the power, 2014-05-17 05:15:07]

Change committed as 271173