Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: DEPS

Issue 2820583002: Reland "Update third_party/checkstyle to 7.6.1" (Closed)
Patch Set: Removing testing changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/update_deps/update_third_party_deps.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: DEPS
diff --git a/DEPS b/DEPS
index f4a9f79770db8a1275d7cc963f17f6596f944b05..9b26049eeac245181792ecb3e051ef003cdc9fed 100644
--- a/DEPS
+++ b/DEPS
@@ -923,6 +923,17 @@ hooks = [
'-s', 'src/buildtools/linux64/clang-format.sha1',
],
},
+ # Pull checkstyle binaries using checked-in hashes.
agrieve 2017/04/19 17:36:54 nit: this comment isn't really useful. I'd remove
+ {
+ 'name': 'checkstyle',
+ 'pattern': '.',
+ 'action': [ 'download_from_google_storage',
+ '--no_resume',
+ '--no_auth',
+ '--bucket', 'chromium-android-tools/checkstyle',
+ '-s', 'src/third_party/checkstyle/checkstyle-7.6.1-all.jar.sha1'
+ ],
+ },
{
'name': 'gvr_static_shim_android_arm',
'pattern': '\\.sha1',
« no previous file with comments | « no previous file | build/android/update_deps/update_third_party_deps.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698