| OLD | NEW |
|---|
| 1 Name: Checkstyle is a development tool to help programmers write Java code that | 1 Name: Checkstyle is a development tool to help programmers write Java code that |
| 2 adheres to a coding standard. | 2 adheres to a coding standard. |
| 3 Short Name: checkstyle | 3 Short Name: checkstyle |
| 4 URL: http://checkstyle.sourceforge.net/ | 4 URL: https://github.com/checkstyle/checkstyle |
| 5 Version: 6.5 | 5 Version: 7.6.1 |
| 6 License: LGPL 2.1 | 6 License: LGPL 2.1 |
| 7 License File: NOT_SHIPPED | 7 License File: NOT_SHIPPED |
| 8 Security Critical: no | 8 Security Critical: no |
| 9 | 9 |
| 10 Description: | 10 Description: |
| 11 Checkstyle is used to validate Java code style on Chromium PRESUBMIT step. | 11 Checkstyle is used to validate Java code style on Chromium PRESUBMIT step. |
| 12 | 12 |
| 13 Local Modifications: | 13 Local Modifications: |
| 14 - Downloaded checkstyle-6.5-all.jar without source code development | 14 None |
| 15 documentation. | 15 |
| 16 Update instructions (requires @google.com account): |
| 17 - Download fat jar from https://sourceforge.net/projects/checkstyle/files/checks
tyle/ |
| 18 - Modify tools/android/checkstyle/checkstyle.py and verify the new fat jar works |
| 19 - Remove existing SHA1 file |
| 20 - If gcloud auth tokens are not set up, run |
| 21 $ download_from_google_storage --config |
| 22 - Upload new fat jar to gcloud. In third_party/checkstyle, run |
| 23 $ upload_to_google_storage.py -b chromium-android-tools/checkstyle {new_far_jar} |
| 24 - Check in new SHA1 file |
| 25 - Before submitting the change, verify presubmit works fine by: |
| 26 1) modifying a Java file and including it in the patch |
| 27 2) running the chromium_presubmit trybot in the CQ on the patch |
| 28 3) reverting the Java file change |
| 29 |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 2820583002:
Reland "Update third_party/checkstyle to 7.6.1" (Closed)
