Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: apps/BUILD.gn

Issue 2820563004: Create separate BUILD.gn for //apps/ui/views (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | apps/DEPS » ('j') | apps/ui/views/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/BUILD.gn
diff --git a/apps/BUILD.gn b/apps/BUILD.gn
index e83a7bf2714569a2e0470e8e86d8ee35a3fc8f03..fae99193fa0d25e67101b71bb21c38df9f150879 100644
--- a/apps/BUILD.gn
+++ b/apps/BUILD.gn
@@ -37,13 +37,12 @@ static_library("apps") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
deps = [
- "//chrome/app/theme:theme_resources",
"//components/keyed_service/content",
"//content/public/browser",
"//content/public/common",
+ "//extensions/browser",
hugoh_UTC2 2017/05/22 15:38:25 Somewhere here, I believe this dependency causes a
Nico 2017/05/22 17:51:41 Sure, just send me a patch.
"//extensions/common",
"//extensions/common/api",
- "//skia",
]
if (is_chromeos) {
@@ -51,21 +50,6 @@ static_library("apps") {
}
}
- if (toolkit_views) {
- sources += [
- "ui/views/app_window_frame_view.cc",
- "ui/views/app_window_frame_view.h",
- ]
- deps += [
- "//cc/paint",
- "//ui/strings",
- "//ui/views",
- ]
- if (enable_extensions) {
- deps += [ "//extensions/browser" ]
- }
- }
-
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
}
« no previous file with comments | « no previous file | apps/DEPS » ('j') | apps/ui/views/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698