apps/ui/views/DEPS - Issue 2820563004: Create separate BUILD.gn for //apps/ui/views

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: apps/ui/views/DEPS

Issue 2820563004: Create separate BUILD.gn for //apps/ui/views (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # TODO(jamescook): Eliminate this by introducing apps_resources.grd, see	2 # TODO(jamescook): Eliminate this by introducing apps_resources.grd, see

3 # crbug.com/306688	3 # crbug.com/306688

4 "+grit/theme_resources.h",	4 "+grit/theme_resources.h",
	Nico 2017/04/21 21:03:08 You can probably remove this line, all the grit in You can probably remove this line, all the grit includes are now qualified and this rule shouldn't match anything any more.
	5 "+cc/paint",

	6 "+extensions",

	7 "+third_party/skia/include",

	8 "+ui",

5 "+ui/strings/grit/ui_strings.h",	9 "+ui/strings/grit/ui_strings.h",
	Nico 2017/04/21 21:03:08 You can remove this now. You can remove this now.
	10

	11 # For default app icon.

	12 "!chrome/grit/theme_resources.h",

6 ]	13 ]

OLD	NEW

« no previous file with comments | « apps/ui/views/BUILD.gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »