memory-infra: Start disentangling tracing from memory-infra

services/resource_coordinator/memory/coordinator/coordinator_impl.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/resource_coordinator/memory/coordinator/coordinator_impl.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/platform_thread.h"
 #include "base/trace_event/memory_dump_manager.h"
 #include "base/trace_event/memory_dump_request_args.h"
+#include "base/trace_event/memory_tracing_frontend.h"
 #include "services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h"
 #include "services/resource_coordinator/public/interfaces/memory/constants.mojom.h"
 #include "services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom.h"
 
+using base::trace_event::MemoryDumpManager;
+using base::trace_event::MemoryTracingFrontend;
+
 namespace {
 
 memory_instrumentation::CoordinatorImpl* g_coordinator_impl;
 
 }  // namespace
 
 namespace memory_instrumentation {
 
 // static
 CoordinatorImpl* CoordinatorImpl::GetInstance() {
   return g_coordinator_impl;
 }
 
 CoordinatorImpl::CoordinatorImpl(bool initialize_memory_dump_manager)
     : failed_memory_dump_count_(0),
       initialize_memory_dump_manager_(initialize_memory_dump_manager) {
   if (initialize_memory_dump_manager) {
     MemoryDumpManagerDelegateImpl::Config config(this);
     auto delegate = base::MakeUnique<MemoryDumpManagerDelegateImpl>(config);
-    base::trace_event::MemoryDumpManager::GetInstance()->set_tracing_process_id(
+    MemoryDumpManager::GetInstance()->set_tracing_process_id(
         mojom::kServiceTracingProcessId);
-    base::trace_event::MemoryDumpManager::GetInstance()->Initialize(
-        std::move(delegate));
+    MemoryDumpManager::GetInstance()->Initialize(std::move(delegate));
+    MemoryTracingFrontend::Initialize(MemoryDumpManager::GetInstance());

[ssid, 2017/04/14 23:33:09]

Doesn't look like the right place for initializing. IIRC there was a plan to
move the coodrinator to a different process, in which case browser will never
get initialized.

[hjd, 2017/04/19 09:54:56]

Moved to be done in MDM init.

   }
   g_coordinator_impl = this;
 }
 
 CoordinatorImpl::~CoordinatorImpl() {
   g_coordinator_impl = nullptr;
 }
 
 void CoordinatorImpl::BindCoordinatorRequest(
     mojom::CoordinatorRequest request) {
@@ skipping 131 matching lines @@
   // Schedule the next queued dump (if applicable).
   if (!queued_memory_dump_requests_.empty()) {
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE,
         base::Bind(&CoordinatorImpl::PerformNextQueuedGlobalMemoryDump,
                    base::Unretained(this)));
   }
 }
 
 }  // namespace memory_instrumentation