chrome/test/media_router/resources/presentation_receiver.html - Issue 2820433003: [Presentation API] Add browser tests for 1-UA mode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/media_router/resources/presentation_receiver.html

Issue 2820433003: [Presentation API] Add browser tests for 1-UA mode (Closed)

Patch Set: resolve code review comments from Derek Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html xmlns="http://www.w3.org/1999/xhtml">
	mark a. foltz 2017/04/18 01:03:44 Spot checking the LayoutTests, I don't think we us Spot checking the LayoutTests, I don't think we use XHTML normally in test pages. Just <html> ? zhaobin 2017/04/18 03:17:10 Done. Show quoted text On 2017/04/18 01:03:44, mark a. foltz wrote: > Spot checking the LayoutTests, I don't think we use XHTML normally in test > pages. Just <html> ? Done.
	3 <head>

	4 <title>MR Integration Basic Test</title>
	mark a. foltz 2017/04/18 01:03:44 Maybe: Media Router Integration Test - Receiver Pa Maybe: Media Router Integration Test - Receiver Page zhaobin 2017/04/18 03:17:11 Done. Show quoted text On 2017/04/18 01:03:44, mark a. foltz wrote: > Maybe: > Media Router Integration Test - Receiver Page Done.
	5 <script type="text/javascript">
	mark a. foltz 2017/04/18 01:03:44 Just <script> Just <script> zhaobin 2017/04/18 03:17:10 Done. Show quoted text On 2017/04/18 01:03:44, mark a. foltz wrote: > Just <script> Done.
	6 const addConnection = connection => {

	7 connection.onconnect = function() {

	8 this.onmessage = event => {

	9 if (event.data == 'close') {

	10 connection.close();
	mark a. foltz 2017/04/18 01:03:44 Use \|this\| or \|connection\| consistently in the eve Use \|this\| or \|connection\| consistently in the event handler. zhaobin 2017/04/18 03:17:11 Done. Show quoted text On 2017/04/18 01:03:44, mark a. foltz wrote: > Use \|this\| or \|connection\| consistently in the event handler. Done.
	11 } else {

	12 connection.send('Pong: ' + event.data);

	13 }

	14 }

	15 };

	16 };

	17

	18 navigator.presentation.receiver.connectionList

	19 .then(list => {

	20 list.onconnectionavailable = evt => {

	21 addConnection(evt.connection);

	22 };

	23 list.connections.map(connection => {

	24 addConnection(connection);

	25 });

	26 });

	27 </script>

	28 </head>

	29 <body>

	30 </body>

	31 </html>

OLD	NEW

« chrome/test/media_router/resources/common.js ('K') | « chrome/test/media_router/resources/common.js ('k') | no next file » | no next file with comments »